This repository was archived by the owner on Jun 27, 2020. It is now read-only.
[qa] Upgraded to Django 2.0 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohithasrk
reviewed
Dec 21, 2017
requirements.txt
Outdated
| openwisp-utils>=0.1.2,<0.2 | ||
| jsonfield | ||
| six | ||
| responses |
Contributor
There was a problem hiding this comment.
@phyxkal This is already included in requirements-test.txt
Contributor
There was a problem hiding this comment.
You can remove the responses from here I suppose
1 similar comment
rohithasrk
approved these changes
Dec 21, 2017
Contributor
rohithasrk
left a comment
rohithasrk
left a comment
There was a problem hiding this comment.
LGTM 👍 Great work @phyxkal. @nemesisdesign A final review from you would be great
Member
|
👍 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.