0.4.0 improvements #53
Conversation
This must be here in order for the <title> tag in the detail.html template to work
jQuery is already available within django
- removed duplication of HTML - removed duplication of JS logic - reload graph directly with JS instead of generating it on the server - removed redundant history views
- more consistent look between frontend & admin - eliminated submit button in favor of change date event
Covering the date overlay for simplicity (no space left)
Having files like test_admin.py is preferable over admin.py because admin.py may be confused with the model admin definitions during development.
nemesifier
force-pushed
the
0.4.0-improvements
branch
from
3fe28ce to
e7e5555
Compare
| linkStrength: 0.1 | ||
| }); | ||
| // the graph may be loaded elsewhere than body | ||
| window.__njg_el__ = window.__njg_el__ || "body"; |
There was a problem hiding this comment.
This file is amazing! Didn't know we could do all these 😮
There was a problem hiding this comment.
probably not optimal because not very easy to read, but a more elegant solution would require more time.
we basically reuse this piece of code to load and reload the graph in frontend, admin and when loading older snapshots, the difference is that in the admin we set window.__njg_el__ to the overlay, and when using snapshots we first fetch the data from the API and then pass the data in the graph directly to the library.
There was a problem hiding this comment.
Yeah. I understand. I really liked how you made it reusable
rohithasrk
left a comment
rohithasrk
left a comment
There was a problem hiding this comment.
This can be merged @nemesisdesign. I understood that there's a lot of JS to learn. 😄
This PR adds some general improvement to the work of @rohithasrk done in version 0.4.0 alpha.
I eliminated some redundancies, added some missing static images for the jquery ui datepicker, slightly improved the UI and other minor improvement.