Skip to content

[core] PPP: Change key type of rt_info cache #32663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[core] PPP: Change key type of rt_info cache #32663

wants to merge 3 commits into from
+17 −4

Conversation

@t-jankowski
Copy link
Contributor

@t-jankowski t-jankowski commented Nov 3, 2025

Details:

  • Map key type changed to weak pointer to avoid raw pointers accidental match on reused memory space.

Tickets:

@t-jankowski
Change key type of rt_info cache
20e2187 
Signed-off-by: Tomasz Jankowski <[email protected]>
@t-jankowski t-jankowski requested a review from a team as a code owner November 3, 2025 15:30
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Nov 3, 2025
praasz
praasz reviewed Nov 4, 2025
View reviewed changes
@praasz praasz added this to the 2026.0 milestone Nov 5, 2025
t-jankowski
t-jankowski commented Nov 7, 2025
View reviewed changes
src/core/src/preprocess/pre_post_process.cpp
Comment on lines +65 to +78
struct WeakNodeHash {
size_t operator()(const std::weak_ptr<ov::Node>& wn) const {
const auto sn = wn.lock();
return sn ? std::hash<ov::Node*>()(sn.get()) : 0;
}
};

struct WeakNodeEqual {
bool operator()(const std::weak_ptr<ov::Node>& lhs, const std::weak_ptr<ov::Node>& rhs) const {
return !lhs.owner_before(rhs) && !rhs.owner_before(lhs);
}
};

std::unordered_map<std::weak_ptr<ov::Node>, ov::RTMap, WeakNodeHash, WeakNodeEqual> m_rt_info_cache;
Copy link
Contributor Author

@t-jankowski t-jankowski Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praasz, the hashing operator has changed as previous one was unstable.

@t-jankowski t-jankowski requested a review from praasz November 7, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MirceaDan99 MirceaDan99 Awaiting requested review from MirceaDan99

@praasz praasz Awaiting requested review from praasz

Assignees

No one assigned

Labels

category: Core OpenVINO Core (aka ngraph)

Projects

None yet

Milestone

2026.0

Development

Successfully merging this pull request may close these issues.

2 participants

@t-jankowski @praasz