Skip to content

Conversation

@11happy
Copy link
Contributor

@11happy 11happy commented Feb 1, 2025

Overview:
This pull request fixes #28678.

Testing:

  • Tested the implementation. Verified other implementations remain unaffected.
    Screenshot from 2025-02-01 09-00-09

CC:

@11happy 11happy requested a review from a team as a code owner February 1, 2025 03:36
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Feb 1, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Feb 1, 2025
Copy link
Collaborator

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. Just fix a few comments

@rkazants rkazants added this to the 2025.1 milestone Feb 1, 2025
@rkazants
Copy link
Collaborator

rkazants commented Feb 1, 2025

build_jenkins

@rkazants
Copy link
Collaborator

rkazants commented Feb 1, 2025

build_jenkins

@rkazants rkazants self-assigned this Feb 1, 2025
@rkazants
Copy link
Collaborator

rkazants commented Feb 1, 2025

@11happy
Copy link
Contributor Author

11happy commented Feb 1, 2025

@11happy, please fix the build: https://github.com/openvinotoolkit/openvino/actions/runs/13090731752/job/36527176177?pr=28773

I have added the unsqueeze header which was causing the build to fail.
thank you

@rkazants
Copy link
Collaborator

rkazants commented Feb 2, 2025

build_jenkins

@rkazants rkazants enabled auto-merge February 2, 2025 08:40
@rkazants rkazants added this pull request to the merge queue Feb 2, 2025
Merged via the queue into openvinotoolkit:master with commit 4c01a98 Feb 2, 2025
182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue][TF FE]: Support complex tensors for SelectV2 operations

3 participants