[core] Fix Coverity auto cause copy in core sources #24430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

praasz merged 6 commits into openvinotoolkit:master from praasz:coverity/fix-auto-causes-copy-in-core-src

May 9, 2024

Contributor

praasz commented May 9, 2024

Details:

Apply changes to remove auto_causes_copy reported by Coverity in core sources.
Avoid copies also reduce bin-size.

Tickets:

N/A


          Fix Coverity auto cause copy in core sources

e4165e3

praasz requested review from itikhono and t-jankowski

May 9, 2024 06:31

praasz requested review from a team as code owners

May 9, 2024 06:31

github-actions bot added the category: Core label

praasz assigned itikhono and t-jankowski

praasz requested a review from mitruska

May 9, 2024 06:31

praasz assigned mitruska

praasz added this to the 2024.2 milestone

vurusovs reviewed

View reviewed changes

src/core/src/op/adaptive_avg_pool.cpp Show resolved Hide resolved

vurusovs reviewed

View reviewed changes

src/core/src/op/adaptive_avg_pool.cpp Show resolved Hide resolved

vurusovs reviewed

View reviewed changes

src/core/src/op/concat.cpp Show resolved Hide resolved

vurusovs reviewed

View reviewed changes

src/core/src/op/space_to_batch.cpp Outdated Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/depth_to_space.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/gather_tree.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/max_pool.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/reverse.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/roll.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/op/shuffle_channels.cpp Show resolved Hide resolved

rkazants reviewed

View reviewed changes

src/core/src/preprocess/preprocess_impls.cpp Show resolved Hide resolved

itikhono approved these changes

View reviewed changes

itikhono commented May 9, 2024

in general, LGTM

praasz added 2 commits

May 9, 2024 09:24


          Align using auto for result from shape_infer

f0429d0


          PPP avoid copy names for dump

a5e3a12

praasz requested review from rkazants and vurusovs

May 9, 2024 07:29

mitruska approved these changes

View reviewed changes

t-jankowski approved these changes

View reviewed changes

src/core/src/op/slice.cpp Outdated Show resolved Hide resolved

praasz added 2 commits

May 9, 2024 15:12


          Revert changes not reported by Coverity

fc4db71


          Merge remote-tracking branch 'origin/master' into coverity/fix-auto-c…

45cf6bc

…auses-copy-in-core-src

praasz enabled auto-merge

May 9, 2024 13:20


          Comment unused variable in PagedAttentionExtension

d6416b3

- keep commented code as already it was there

praasz added this pull request to the merge queue

Merged via the queue into openvinotoolkit:master with commit cf76c9d

praasz deleted the coverity/fix-auto-causes-copy-in-core-src branch

May 9, 2024 18:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mitruska mitruska approved these changes

t-jankowski t-jankowski approved these changes

vurusovs Awaiting requested review from vurusovs

rkazants Awaiting requested review from rkazants

+1 more reviewer

itikhono itikhono approved these changes

Labels