Expose Model.get_output_size() method to Node.js API #23822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vishniakov-nikolai
left a comment
vishniakov-nikolai
left a comment
There was a problem hiding this comment.
Minor comments
vishniakov-nikolai
approved these changes
Apr 4, 2024
Co-authored-by: Vishniakov Nikolai <[email protected]>
praasz
reviewed
Apr 15, 2024
almilosz
requested changes
Apr 16, 2024
Contributor
almilosz
left a comment
almilosz
left a comment
There was a problem hiding this comment.
The CIs are failing because there is a possible loss of data when you convert size_t to double.
Consider representing output_size as different Napi::Value
auto-merge was automatically disabled
April 17, 2024 18:12
Head branch was pushed to by a user without write access
almilosz
reviewed
Apr 22, 2024
Contributor
almilosz
left a comment
almilosz
left a comment
There was a problem hiding this comment.
After fixing merge conflicts it's ready to merge. Be careful not to remove get/set FriendlyName() methods
vishniakov-nikolai
approved these changes
May 10, 2024
Contributor
|
build_jenkins |
almilosz
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23567
What has been done: