improve: remove boosts, better compilation and GHA support#31
Merged
Conversation
Removed boosts (replaced with equivalent on std 14/17/20) Removed manual json library implementation using boost and added nlohmann-json So two additional libraries will be needed to compile: asio, nlohmann-json I also removed OTGZ support by default and disabled it, making it optional (needs to be enabled). Anyone who wants to use it will need to activate this, I think it's ideal since few should use it, so a majority don't use it, which is fairer that those who need to activate it to use it than those who don't need to have this in their program.
dudantas
force-pushed
the
improve-remove-boosts-and-better-compilation
branch
from
1600519 to
27131d7
Compare
dudantas
force-pushed
the
improve-remove-boosts-and-better-compilation
branch
from
6c57f03 to
b7611dd
Compare
dudantas
force-pushed
the
improve-remove-boosts-and-better-compilation
branch
from
044ee5c to
692f8da
Compare
dudantas
changed the title
majestyotbr
approved these changes
Mar 28, 2023
dudantas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed boosts (replaced with equivalent on std 14/17/20)
Removed manual json library implementation using boost and added nlohmann-json
So two additional libraries will be needed to compile:
asio, nlohmann-json (see wiki)
Also removed OTGZ support by default and disabled it, making it optional (needs to be enabled). Anyone who wants to use it will need to activate this, I think it's ideal since few should use it, so a majority don't use it, which is fairer that those who need to activate it to use it than those who don't need to have this in their program.
Added GitHub Actions workflow for Windows (vs 2022) and Ubuntu 22.04