fix: packet Cyclopedia house auction 13.40#970
Merged
majestyotbr merged 24 commits intoopentibiabr:mainfrom Jan 3, 2025
Merged
fix: packet Cyclopedia house auction 13.40#970majestyotbr merged 24 commits intoopentibiabr:mainfrom
majestyotbr merged 24 commits intoopentibiabr:mainfrom
Conversation
last commits 26a2d60 "Merge branch 'main' into test-house" on Nov 12, 2024, 02:28 PM
… the if statement.) -Use the init-statement to declare "isOwner" inside the if statement.
luanluciano93
previously requested changes
Nov 25, 2024
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
kokekanon
changed the title
Co-authored-by: Luan Luciano <luanluciano@outlook.com>
Contributor
Author
|
canary's pr # 3022 was approved today. this pr can now be merged. |
|
majestyotbr
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix packets , NO features (lua.otui) [I don't know what it is]
Description
I was test. this pr opentibiabr/canary#3022
PR sent packets when logging
I solved that problem, the rest is theoretical, I don't know how to test that.
last commits
Behavior
Actual
Packet error
Expected
Do this and that happens
Fixes
Type of change
How Has This Been Tested
untest , until the end of the pr
Test Configuration:
26a2d60Checklist
ONLY APPROVE IF PR CANARY # 3022 IS murge. if not close xd