fix: Further optimize Color to_lower_ascii

[divinity76]

one less branch, and it really shows on microbenchmarks: https://quick-bench.com/q/pxrI9X9kVtpApj4iIeYnolxgfz4

• 1.6 times faster than fix: optimize color tolower #1490
• 7.2 times faster than the original pre-1490 tolower.

how has this been tested?: https://wandbox.org/permlink/wJG4CS4oghvlwQxZ

Summary by CodeRabbit

• Refactor
  • Minor code style improvements to internal utilities with no impact on functionality or user experience.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A stylistic refactor of the to_lower_ascii function in the color utility module. The character lowercasing loop was modified to use reference binding and conditional expressions, maintaining identical observable behavior without changing control flow or functionality.

Changes

Cohort / File(s)	Summary
Stylistic refactor src/framework/util/color.cpp	Minor refactoring of to_lower_ascii: restructured character transformation loop using reference binding and conditional expression. Functionally equivalent with no behavioral changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

Whiskers twitch at code so clean,
A loop refined, a style serene,
Reference bindings dance with grace,
The ASCII letters find their place,
hops about 🐰 Lower, ever lower we go!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: a stylistic optimization to the Color::to_lower_ascii function to reduce branching, directly matching the core objective of improving performance.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

This PR is stale because it has been open 45 days with no activity.