Skip to content

fix: ferumbras ascension quest #3646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majestyotbr merged 3 commits into from
Aug 23, 2025
Merged

fix: ferumbras ascension quest #3646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa4de78
Update script to use the lastkiller instead of undefined player
Pablodotnet Aug 20, 2025
9c3573e
Change to use count from game storage instead of player
Pablodotnet Aug 20, 2025
22458b6
Fix ferumbras mortal shell kill script
Pablodotnet Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion data-otservbr-global/scripts/quests/ferumbras_ascension/creaturescripts_bosses_kill.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,18 @@ local crystals = {
}

local function transformCrystal(player)
if type(player) ~= "userdata" or not player:isPlayer() then
print("[Error] transformCrystal: invalid player argument")
return
end

for c = 1, #crystals do
local crystal = crystals[c]
player:setStorageValue(crystal.globalStorage, 0)
Game.setStorageValue(crystal.globalStorage, 0)
player:setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals, 0)
Game.setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals, 0)

local item = Tile(crystal.crystalPosition):getItemById(14961)
if item then
item:transform(14955)
Expand Down Expand Up @@ -110,22 +118,31 @@ function ascendantBossesKill.onDeath(creature)
local cooldownTime = bossConfig.cooldown * 3600
local nextAvailableTime = os.time() + cooldownTime
player:setStorageValue(bossConfig.storage, nextAvailableTime)

local cooldownMessage = formatCooldownMessage(bossConfig.cooldown)
player:sendTextMessage(MESSAGE_EVENT_ADVANCE, "You have defeated " .. bossName .. ". You can challenge this boss again in " .. cooldownMessage .. ".")
end
end)

-- Handle teleport transformation
local teleport = Tile(bossConfig.teleportPos):getItemById(1949)
if teleport then
teleport:transform(22761)
teleport:getPosition():sendMagicEffect(CONST_ME_THUNDER)
teleport:setDestination(bossConfig.godbreakerPos)

addEvent(revertTeleport, 1 * 60 * 1000, bossConfig.teleportPos, 22761, 1949, Position(33319, 32318, 13))
end

-- Special case for Ferumbras Mortal Shell
if creature:getName():lower() == "ferumbras mortal shell" then
onDeathForDamagingPlayers(creature, function(creature, player)
addEvent(transformCrystal, 2 * 60 * 1000, player)
addEvent(function(playerId)
local player = Player(playerId)
if player then
transformCrystal(player)
end
end, 2 * 60 * 1000, player:getId())
end)
end

Expand Down
10 changes: 5 additions & 5 deletions ...otservbr-global/scripts/quests/ferumbras_ascension/creaturescripts_rift_invader_death.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,26 @@ function riftInvaderDeath.onDeath(creature, corpse, lasthitkiller, mostdamagekil
for i = 1, #crystals do
local crystal = crystals[i]
if creature:getPosition():isInRange(crystal.fromPosition, crystal.toPosition) then
if player:getStorageValue(crystal.globalStorage) > 8 then
if Game.getStorageValue(crystal.globalStorage) > 8 then
local item = Tile(crystal.crystalPosition):getItemById(14955)
if not item then
return true
end
item:transform(14961)
player:setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals, player:getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals) + 1)
Game.setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals, Game.getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals) + 1)
end
if player:getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals) == 8 then
if Game.getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.Crystals.AllCrystals) == 8 then
local creature = Tile(config.bossPos):getTopCreature()
creature:say("NOOOOOOOOOOO!", TALKTYPE_MONSTER_YELL)
creature:say("FERUMBRAS BURSTS INTO SOUL SPLINTERS!", TALKTYPE_MONSTER_YELL, nil, nil, Position(33392, 31475, 14))
creature:remove()
for a = 1, #crystals do
local crystalEffect = crystals[i]
local crystalEffect = crystals[a]
crystalEffect.crystalPosition:sendMagicEffect(CONST_ME_FERUMBRAS)
Game.createMonster("Ferumbras Soul Splinter", Position(33392, 31473, 14), false, true)
end
end
player:setStorageValue(crystal.globalStorage, player:getStorageValue(crystal.globalStorage) + 1)
Game.setStorageValue(crystal.globalStorage, Game.getStorageValue(crystal.globalStorage) + 1)
lasthitkiller:say("The negative energy of the rift creature is absorbed by the crystal!", TALKTYPE_MONSTER_SAY, nil, nil, crystal.crystalPosition)
lasthitkiller:say("ARGH!", TALKTYPE_MONSTER_SAY, nil, nil, Position(33392, 31473, 14))
end
Expand Down
4 changes: 2 additions & 2 deletions data-otservbr-global/scripts/quests/ferumbras_ascension/movements_vortex.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ function vortex.onStepIn(creature, item, position, fromPosition)

monster:remove()
position:sendMagicEffect(CONST_ME_POFF)
player:setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence, player:getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence) + 1)
if player:getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence) >= 8 then
Game.setStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence, Game.getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence) + 1)
if Game.getStorageValue(Storage.Quest.U10_90.FerumbrasAscension.FerumbrasEssence) >= 8 then
Game.createMonster("Destabilized Ferumbras", config.bossPos, true, true)
for i = 1, config.maxSummon do
Game.createMonster("Rift Fragment", Position(math.random(33381, 33403), math.random(31462, 31483), 14), true, true)
Expand Down