[Backmerge][OSDEV-2318] Disable prevent destroy for msk cluster

[VadimKovalenkoSNF]

Backmerge PR of #864

Follow-up fix for OSDEV-2318

Disable prevent_destroy for msk cluster to unblock Pre-prod deletion.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

📝 Walkthrough

Walkthrough

The lifecycle.prevent_destroy setting in the AWS MSK configuration resource was changed from true to false, removing the deletion safeguard. A preceding comment line was also removed.

Changes

Cohort / File(s)	Summary
MSK Configuration Lifecycle deployment/terraform/kafka.tf	Changed lifecycle.prevent_destroy from true to false in aws_msk_configuration.msk_config, allowing the Terraform-managed MSK configuration to be destroyed. Removed preceding comment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• protsack-stephan
• vlad-shapik
• roman-stolar

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change—disabling prevent_destroy for the MSK cluster—which matches the changeset that removed the prevent_destroy safeguard from the Terraform configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check	✅ Passed	The pull request description clearly describes the changeset: disabling prevent_destroy for MSK cluster as a follow-up fix, matching the actual code change from true to false.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

deployment/terraform/kafka.tf (1)

25-31: Acknowledge the change; ensure it remains temporary and consider adding safeguards.

Disabling prevent_destroy is necessary to unblock the Pre-prod environment deletion. However, since this is a shared Terraform configuration applied to all environments through variable inputs, the change will affect deletion protection across all deployments—not just Pre-prod.

Since the code comment indicates this configuration should be "removed when no longer needed," recommend:

1. Re-enable prevent_destroy = true after the Pre-prod deletion is complete, or
2. Add a comment documenting the temporary nature and expected removal timeline to prevent accidental permanent removal in other environments.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e5361da and 29f83d9.

📒 Files selected for processing (1)

• deployment/terraform/kafka.tf

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)

• GitHub Check: init-and-plan
• GitHub Check: run-flake8-linter
• GitHub Check: run-eslint-linter-and-prettier-formatter
• GitHub Check: get-base-branch-contricleaner-cov
• GitHub Check: run-dd-code-quality
• GitHub Check: run-contricleaner-code-quality
• GitHub Check: get-base-branch-dd-cov
• GitHub Check: run-integration-test-code-quality
• GitHub Check: run-countries-code-quality
• GitHub Check: get-base-branch-django-cov
• GitHub Check: run-fe-code-quality
• GitHub Check: run-django-code-quality
• GitHub Check: get-base-branch-fe-cov
• GitHub Check: get-base-branch-countries-cov

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[barecheck]

React App | Jest test suite - Code coverage report

Total: 40.32%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 55.73%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.75%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Django App | Unittest test suite - Code coverage report

Total: 81.87%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered