[OSDEV-2293] ISIC-4 section displayed for non-ISIC-4 data

[roman-stolar]

OSDEV-2293 ISIC-4 section displayed for non-ISIC-4 data

• Fixed the ISIC-4 section displaying on production location profiles when submitted objects contained no valid ISIC-4 fields (section, division, group, class). Enhanced filtering logic to only render the ISIC-4 section when at least one valid field contains data.

[barecheck]

React App | Jest test suite - Code coverage report

Total: 39.16%

Your code coverage diff: 0.06% ▴

✅ All code changes are covered

[barecheck]

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 55.73%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.75%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[barecheck]

Django App | Unittest test suite - Code coverage report

Total: 81.57%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR addresses OSDEV-2293 by refining ISIC-4 section rendering logic in FacilityDetailsGeneralFields. The component now filters out ISIC-4 groups with no valid field data instead of rendering them with empty values. Changes include filtering logic refinement, corresponding test cases, and release notes documentation.

Changes

Cohort / File(s)	Change Summary
Release Notes doc/release/RELEASE-NOTES.md	Added bugfix entry for OSDEV-2293 documenting that ISIC-4 section no longer renders on production location profiles when submitted objects contain no valid ISIC-4 fields
ISIC-4 Filtering Logic src/react/src/components/FacilityDetailsGeneralFields.jsx	Refined filtering of formatted field entries in isic_4 extended field handling to discard entries with empty arrays or falsy non-array values, preventing rendering of groups with no meaningful content
Test Cases src/react/src/__tests__/components/FacilityDetailsGeneralFields.test.js	Added two new test cases verifying ISIC-4 section is not rendered when containing invalid field data or when all ISIC-4 fields have empty values

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focused, cohesive changes all addressing the same bug
• Simple filtering logic modification without architectural impact
• New tests directly validate the bugfix with straightforward assertions
• Low logic density with minimal file scope

Possibly related PRs

• [OSDEV-2244] Display ISIC 4 hierarchy fields on production location profiles #812: Both PRs modify the ISIC-4 rendering pipeline; this PR's filtering fix directly relates to the retrieved PR's ISIC-4 display changes in FacilityDetailsGeneralFields.

Suggested reviewers

• mazursasha1990
• vladsha-dev
• VadimKovalenkoSNF

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main bug fix: ISIC-4 section was displayed for non-ISIC-4 data, which is directly addressed by the changeset.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the bug fix and enhanced filtering logic that directly corresponds to the code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch OSDEV-2293-isic-4-section-display-non-isic-4-data

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b7f637 and d774775.

📒 Files selected for processing (1)

• doc/release/RELEASE-NOTES.md (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• doc/release/RELEASE-NOTES.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

• GitHub Check: run-integration-test-code-quality
• GitHub Check: run-eslint-linter-and-prettier-formatter
• GitHub Check: run-django-code-quality
• GitHub Check: run-dd-code-quality
• GitHub Check: get-base-branch-countries-cov
• GitHub Check: run-countries-code-quality
• GitHub Check: run-flake8-linter
• GitHub Check: get-base-branch-contricleaner-cov
• GitHub Check: get-base-branch-dd-cov
• GitHub Check: get-base-branch-django-cov
• GitHub Check: run-contricleaner-code-quality
• GitHub Check: run-fe-code-quality
• GitHub Check: get-base-branch-fe-cov

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[VadimKovalenkoSNF]

LGTM