Skip to content

[Quickfix-v.2.16][OSDEV-2285] Adjust multiupload for isic_4 fields#825

Merged
VadimKovalenkoSNF merged 3 commits intoreleases/v.2.16from
Fix-multi-isic_4-fields
Nov 27, 2025
Merged

[Quickfix-v.2.16][OSDEV-2285] Adjust multiupload for isic_4 fields#825
VadimKovalenkoSNF merged 3 commits intoreleases/v.2.16from
Fix-multi-isic_4-fields

Conversation

@VadimKovalenkoSNF
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF commented Nov 26, 2025 •
edited by atlassian bot
Loading

Follow-up fix for OSDEV-2285

@VadimKovalenkoSNF VadimKovalenkoSNF self-assigned this Nov 26, 2025
@barecheck
Copy link

barecheck bot commented Nov 26, 2025 •
edited
Loading

React App | Jest test suite - Code coverage report

Total: 37.61%

Your code coverage diff: 0.16% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Nov 26, 2025 •
edited
Loading

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 55.73%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Nov 26, 2025 •
edited
Loading

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.75%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Nov 26, 2025 •
edited
Loading

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 26, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@barecheck
Copy link

barecheck bot commented Nov 26, 2025

Django App | Unittest test suite - Code coverage report

Total: 81.51%

Your code coverage diff: -0.03% ▾

✅ All code changes are covered

roman-stolar
roman-stolar approved these changes Nov 26, 2025
View reviewed changes
Copy link
Contributor

@roman-stolar roman-stolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

@VadimKovalenkoSNF VadimKovalenkoSNF merged commit cc4ab31 into releases/v.2.16 Nov 27, 2025
39 of 40 checks passed
@VadimKovalenkoSNF VadimKovalenkoSNF deleted the Fix-multi-isic_4-fields branch November 27, 2025 09:24
@VadimKovalenkoSNF VadimKovalenkoSNF mentioned this pull request Dec 1, 2025
Merged
@VadimKovalenkoSNF VadimKovalenkoSNF changed the title [Quickfix][OSDEV-2285] Adjust multiupload for isic_4 fields [Quickfix-v.2.16][OSDEV-2285] Adjust multiupload for isic_4 fields Dec 1, 2025
VadimKovalenkoSNF added a commit that referenced this pull request Dec 1, 2025
@VadimKovalenkoSNF
[Backmerge][OSDEV-2285] Adjust multiupload for isic_4 fields (#829)
631d5b4 
Backmerge of #825

Fix for
[OSDEV-2285](https://opensupplyhub.atlassian.net/browse/OSDEV-2285)

1. Updated the backfill script, including support for the `--os-id`
parameter alongside `--singleisic`.
2. Updated multiupload handling for `isic_4` fields on both BE and FE.

[OSDEV-2285]:
https://opensupplyhub.atlassian.net/browse/OSDEV-2285?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@protsack-stephan protsack-stephan protsack-stephan approved these changes

@vlad-shapik vlad-shapik Awaiting requested review from vlad-shapik

+1 more reviewer

@roman-stolar roman-stolar roman-stolar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VadimKovalenkoSNF VadimKovalenkoSNF

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@VadimKovalenkoSNF @protsack-stephan @roman-stolar