Skip to content

[OSDEV-2260] Update the logic about saving extended fields for the Claim flow#802

Merged
protsack-stephan merged 3 commits intoreleases/v.2.15from
OSDEV-2260-update-saving-of-extended-fields
Nov 7, 2025
Merged

[OSDEV-2260] Update the logic about saving extended fields for the Claim flow#802
protsack-stephan merged 3 commits intoreleases/v.2.15from
OSDEV-2260-update-saving-of-extended-fields

Conversation

@protsack-stephan
Copy link
Collaborator

@protsack-stephan protsack-stephan commented Nov 7, 2025

Removed the unnecessary facility_type checks in the facilities_view_set.py to support proper saving of the data. The function assumed that the value is an array and that caused errors in the creation of extended fields.

On front-end data format has been changed to send array values as a pipe-separated (|) string instead of a comma-separated one. The extended_fields.py file has been updated to correctly parse this new pipe-delimited format, ensuring data is handled correctly.

@barecheck
Copy link

barecheck bot commented Nov 7, 2025

React App | Jest test suite - Code coverage report

Total: 37.07%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

vlad-shapik
vlad-shapik previously approved these changes Nov 7, 2025
Copy link
Contributor

@vlad-shapik vlad-shapik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barecheck
Copy link

barecheck bot commented Nov 7, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 55.73%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Nov 7, 2025

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@barecheck
Copy link

barecheck bot commented Nov 7, 2025

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.75%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@protsack-stephan protsack-stephan enabled auto-merge (squash) November 7, 2025 12:53
@protsack-stephan protsack-stephan merged commit 8581ce0 into releases/v.2.15 Nov 7, 2025
20 of 21 checks passed
@protsack-stephan protsack-stephan deleted the OSDEV-2260-update-saving-of-extended-fields branch November 7, 2025 13:13
vlad-shapik pushed a commit that referenced this pull request Nov 17, 2025
…aim flow (#802)

Removed the unnecessary `facility_type` checks in the
`facilities_view_set.py` to support proper saving of the data. The
function assumed that the value is an array and that caused errors in
the creation of extended fields.

On front-end data format has been changed to send array values as a
**pipe-separated (`|`) string** instead of a comma-separated one. The
`extended_fields.py` file has been updated to correctly parse this new
pipe-delimited format, ensuring data is handled correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants