[OSDEV-2260] Update the logic about saving extended fields for the Claim flow#802
Merged
protsack-stephan merged 3 commits intoreleases/v.2.15from Nov 7, 2025
Conversation
React App | Jest test suite - Code coverage reportTotal: 37.07%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 55.73%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.75%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
0460fa8
vlad-shapik
approved these changes
Nov 7, 2025
|
vlad-shapik
pushed a commit
that referenced
this pull request
Nov 17, 2025
…aim flow (#802) Removed the unnecessary `facility_type` checks in the `facilities_view_set.py` to support proper saving of the data. The function assumed that the value is an array and that caused errors in the creation of extended fields. On front-end data format has been changed to send array values as a **pipe-separated (`|`) string** instead of a comma-separated one. The `extended_fields.py` file has been updated to correctly parse this new pipe-delimited format, ensuring data is handled correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Removed the unnecessary
facility_typechecks in thefacilities_view_set.pyto support proper saving of the data. The function assumed that the value is an array and that caused errors in the creation of extended fields.On front-end data format has been changed to send array values as a pipe-separated (
|) string instead of a comma-separated one. Theextended_fields.pyfile has been updated to correctly parse this new pipe-delimited format, ensuring data is handled correctly.