[OSDEV-1886] Disable script crash when getting exit code 254 from aws cli when deleting Lambda@Edge function by roninzp · Pull Request #603 · opensupplyhub/open-supply-hub

roninzp · 2025-04-24T12:16:32Z

Adding the set +e command is necessary to ensure that the script does not terminate on an error, allowing us to handle the exit code of the Lambda function deletion command manually. This is especially useful in cases where the function might already be deleted or doesn't exist — the aws lambda delete-function command would return an error, but with set +e, we can catch that error and decide how to proceed.

…eting Lambda@Edge function

coderabbitai · 2025-04-24T12:18:40Z

📝 Walkthrough

## Walkthrough

The script responsible for deleting AWS Lambda function versions was updated to include a `set +e` command before the deletion loop. This adjustment allows the script to continue running even if an error occurs during the deletion process. By capturing the exit code of the `aws lambda delete-function` command, the script can now identify specific error messages, such as those related to function replication, and implement a retry mechanism with a delay instead of terminating immediately.

## Changes

| File(s)                     | Change Summary                                                                                                         |
|-----------------------------|-----------------------------------------------------------------------------------------------------------------------|
| deployment/delete_lambda     | Added `set +e` before the Lambda version deletion loop to disable immediate exit on error, enabling manual error handling and retries for specific AWS Lambda deletion errors. |
| doc/release/RELEASE-NOTES.md| Expanded release notes for OSDEV-1886 to describe the added retry mechanism and internal exit code management preventing forced script termination during Lambda deletion. |

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant Script
    participant AWS Lambda

    loop For each Lambda version
        Script->>AWS Lambda: delete-function
        alt Deletion succeeds
            Script-->>Script: Continue to next version
        else Deletion fails (replication error)
            Script-->>Script: Wait, then retry deletion
        else Other errors
            Script-->>Script: Handle error accordingly
        end
    end

Possibly related PRs

[OSDEV-1886] Fix script for delete Lamda@Edge functions #597: Both PRs modify the Lambda deletion script to handle retries on deletion errors related to replication, improving the robustness of Lambda@Edge function version deletions.
[OSDEV-1886] Delete Lambda@Edge function before destroying environment #567: Enhances the Lambda deletion script by adding error handling and retry logic during Lambda version deletion, directly building upon the same script and functionality.

Suggested reviewers

VadimKovalenkoSNF
vladsha-dev


</details>

<!-- walkthrough_end -->


---

<details>
<summary>📜 Recent review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 968c28a90f0cdfd0170da19e6bf5c583e49292e2 and 2b3c59a24dfec871bd66849e7b4b3e01fc8882ee.

</details>

<details>
<summary>📒 Files selected for processing (1)</summary>

* `deployment/delete_lambda` (1 hunks)

</details>

<details>
<summary>✅ Files skipped from review due to trivial changes (1)</summary>

* deployment/delete_lambda

</details>

<details>
<summary>⏰ Context from checks skipped due to timeout of 90000ms (13)</summary>

* GitHub Check: run-flake8-linter
* GitHub Check: run-integration-test-code-quality
* GitHub Check: run-fe-code-quality
* GitHub Check: run-eslint-linter-and-prettier-formatter
* GitHub Check: run-django-code-quality
* GitHub Check: run-dd-code-quality
* GitHub Check: run-countries-code-quality
* GitHub Check: run-contricleaner-code-quality
* GitHub Check: get-base-branch-fe-cov
* GitHub Check: get-base-branch-dd-cov
* GitHub Check: get-base-branch-django-cov
* GitHub Check: get-base-branch-contricleaner-cov
* GitHub Check: get-base-branch-countries-cov

</details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNxU3bABsvkCiQBHbGlcABpIcVwvOkgAIgBtAHkAZQARAFEANTAARgAOPIA2AF1IVKQVaPsGCnhuXEYqRFhIAHdYMkhSXHEMIkgSAA91BSVIACYAVgAWSAAzChZ0VuQGLx12zqVo3v6AGTRmAVo0AAF02lJ57AwxeHwMUNj0Wlp/RERpdCwkBxIULBoaq1eoRWDUAE0KhiZCtdQtACCAHVkpADkcTtdbuIHogNDAOoxwX1/vAMBJ8F4pMg0K8yf1cISAAafBoAahITIUTgw9AIYP+iBqdU0BNQzEU8Dm8AY1HuWF4JCkGFwyEZguFoIWSyhzDJcr6KFYdHg1BIXnkm0BWEoiz4+AYDGwFGQtGd9IFA0Gojw8v4c09TLQK0gXkOxyB2xINDAcxudweXKYPNo+OS3FEUplaB8snCjNQOa8+BD6uBIoi+EgxNoVTLQxGTDGzEw2CLebaCAYLVQ8GY3HwFFwmAaVs96IjWITWGHFG6MTmg8gUZxWD1RFgDRz/lp8gE/xXMSXtHwXww+AaDcQooAklgHN3GGhPoh84TkaiAMJ7G/clu8vxo2dDAaRtCg7XCAQ8DaeFIBZaNIA5Jk3w1EEGllLBZVwR8C2QW0l0weglAYeAxlgEtKx4RYGBIGI4UZfBoJqZ8ED6DQjH0YxwCgMh6HwAM0DwQhSHIKgaHoZM2BVLheH4YRRHEalIDkUZlFUdQtB0TiTCgdxkELQEhOIMhlHEv92C4KhWnsRwWxcZT5CbNS1E0bRdDAQwuNMAwlG4YtZCk3AAHpDwAfTDDE0A4AxYligwLEgBEb2M0SzXoBwnHs/iiUwUhEDcQkhTQl5aBpODWUQzk/0Io02FoU0aAtZSSEXfxPWLfBuDBCFD2QCdMTjbE/SkF15TxMVXQqARojVQrNVwAByV0WsErwGn3cEJHue0AwbXZapNM0moeb5HJYf96DmbQvGdEhwiLEsPX/NtfBrdZDWy+thgaa9qGwZBPuZYNkAiydD1jeNVyTc7CPxPScpJAYMEqL4yyKit+Vlepbu+egyUQDMxE9fD7TwTwGkBg9zWjP1JMI8IlBoImCczaUGAGcClzYD40DyyAAAoHxaZ9PUG6dmo9fw/OzcSAEp7oAvs/JIQL0EA3B7LYbtMCQZgYMZNXtjQeR8ZoWl/QiSg9WR/aTrLaUXUvTmKHYox4ssBE1tMsbKLLYiwzEn3sqGAchyPPhPGmmUkcieBpCMAA5B4SHY2LYg47yTwYIL/GiZ8SCCmx0j2dIEWSdIwATxJoHSZINGYWhorT93EuSkTTJiDK7PkbLtZJfKDDgf5c5IfPIHPGhkFalAPmCSAUgybJ8iKas0CkZrOhDwiYn5Mk1mwMZMBK9R5RzeZ4EGfErH8LbGMQC0UPHi8vgeJrAvlBcL49NH5sow80XDCcc4lx/hi1XDIFqg5SQYAWM+DW2AxA4yUNeCgCDVwAk9KkEIix5DpHJPARYGBVYAHF1AAAlsACDaIOAA1nMYsrQ4aEmwNwE4ZkJ5ngojmRAVZkHCn3J6JW0RApyhOtlIEWtiS60ooqZUDRWo0XSr/XU+p0FulqIaP21N0G8AdNIca6ZWbZlzI/dG9QlpekbIoUkyBzzWX/LzGIZIoTI1zJRNe+BSLoAEKg0EKibbynCGQBwGj+i6IzHwN6HpKbLm0X6ei5FoI/2KntD0ioWy4FuhaV2CVPZQlESBX2hJ/bOAKQDXagxQ5mSXJHdY7N2An3jgYJO5AmH/D7nzZw/x1h6jMvyLOjh2AFIwWWEeY8OFT3gFUGqJ4n5bjmHMBSp0vRVPDjwShdTVIx0aXiGKcUDCcQMDpJGfEBJGXbmJGIkkLJ+GDDZTKe4zpKCoOpVyWkPJHO4n+dQoVSKIFCjfOOrQ6ChV+kOdynljlzDyLROYABOOFcwADMOQSBwoYNMJFcxxhwpxZMAA7LSWg0w4X4qRQwJFkwVAkEKFMAR2kvlwsKHkBg4w8hoDhQABjmJyhgtA5i0E5TkfFnKTg5DhTSgQcxJgMEmHkJFJASU4vGCQcYELPkQAmAIclkw4VoHGNMflog8j4pyMcQozKSUkHxQIaY2qSBCrmAwAoeQVX/EOccySPy/kAqVECkFvEIVAA -->

<!-- internal state end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=opensupplyhub/open-supply-hub&utm_content=603):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Generate unit testing code for this file.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai generate unit testing code for this file.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and generate unit testing code.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

deployment/delete_lambda (1)
83-99: Effective error handling implementation

The error handling logic is well-implemented. You're capturing the exit code, properly identifying replication-related errors for retry, and handling unexpected errors by displaying them and exiting.

Consider adding set -e at the end of the deletion loop (after line 101) to restore the strict error handling for any potential future commands added to the script.
done

+ set -e

echo "Process completed successfully."

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7481349 and f8eef99.

📒 Files selected for processing (1)

deployment/delete_lambda (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (13)

GitHub Check: run-integration-test-code-quality
GitHub Check: run-flake8-linter
GitHub Check: run-fe-code-quality
GitHub Check: run-eslint-linter-and-prettier-formatter
GitHub Check: run-django-code-quality
GitHub Check: run-dd-code-quality
GitHub Check: run-countries-code-quality
GitHub Check: run-contricleaner-code-quality
GitHub Check: get-base-branch-fe-cov
GitHub Check: get-base-branch-countries-cov
GitHub Check: get-base-branch-contricleaner-cov
GitHub Check: get-base-branch-django-cov
GitHub Check: get-base-branch-dd-cov

🔇 Additional comments (1)

deployment/delete_lambda (1)

74-76: Excellent addition to improve error handling!

Adding set +e here is a good solution for handling the error when deleting Lambda@Edge functions. This allows the script to continue execution and implement the retry mechanism when encountering the "function is replicated" error condition.

barecheck · 2025-04-24T12:19:20Z