Skip to content

[OSDEV-1672] SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items#510

Merged
Innavin369 merged 6 commits intomainfrom
OSDEV-1672-fix-ui-on-collecting-contribution-data-page
Feb 13, 2025
Merged

[OSDEV-1672] SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items#510
Innavin369 merged 6 commits intomainfrom
OSDEV-1672-fix-ui-on-collecting-contribution-data-page

Conversation

@Innavin369
Copy link
Contributor

@Innavin369 Innavin369 commented Feb 12, 2025

OSDEV-1672 - SLC. Implement collecting contribution data page (FE) - All Multi-Selects on the page have been fixed. They resize based on the number of items selected.
Screenshot 2025-02-12 at 11 51 25

@Innavin369 Innavin369 self-assigned this Feb 12, 2025
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:51 — with GitHub Actions Inactive
@Innavin369 Innavin369 changed the title [OSDEV-1672](https://opensupplyhub.atlassian.net/browse/OSDEV-1672) SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items [OSDEV-1672 SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items Feb 12, 2025
@Innavin369 Innavin369 changed the title [OSDEV-1672 SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items [OSDEV-1672] SLC. Collecting contribution data page (FE) Multi-select lists are not resizing depending on the selected items Feb 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2025

📝 Walkthrough

Walkthrough

This pull request updates the release documentation and a React component. The release notes now include detailed validation rules for the geo-bounding box query on the GET /api/v1/production-locations/ endpoint, specifying requirements for coordinate types and ranges. Additionally, it introduces a note regarding a frontend change where multi-select elements on the contribution data page resize based on the number of items selected. In the React component, the select styling has been modified to use a minimum height instead of a fixed height, and a minor comment formatting adjustment was made.

Changes

File(s) Change Summary
doc/release/RELEASE-NOTES.md Added validation rules for geo-bounding box coordinates (integer checks, range limits, and coordinate order) and documented FE changes for multi-select resizing on the contribution page.
src/react/src/components/Contribute/ProductionLocationInfo.jsx Changed select component styling from height: '56px' to minHeight: '56px' for flexible sizing; adjusted comment formatting.

Possibly related PRs

Suggested reviewers

  • mazursasha1990
  • roman-stolar
  • VadimKovalenkoSNF
  • vladsha-dev

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38508bd and 6f4bd3d.

📒 Files selected for processing (2)
  • doc/release/RELEASE-NOTES.md (3 hunks)
  • src/react/src/components/Contribute/ProductionLocationInfo.jsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/react/src/components/Contribute/ProductionLocationInfo.jsx
  • doc/release/RELEASE-NOTES.md
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: run-integration-test-code-quality
  • GitHub Check: run-flake8-linter
  • GitHub Check: run-eslint-linter-and-prettier-formatter
  • GitHub Check: run-dd-code-quality
  • GitHub Check: run-django-code-quality
  • GitHub Check: run-countries-code-quality
  • GitHub Check: run-contricleaner-code-quality
  • GitHub Check: get-base-branch-countries-cov
  • GitHub Check: get-base-branch-dd-cov
  • GitHub Check: get-base-branch-contricleaner-cov
  • GitHub Check: get-base-branch-fe-cov
  • GitHub Check: run-fe-code-quality
  • GitHub Check: get-base-branch-django-cov

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:54 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Feb 12, 2025

React App | Jest test suite - Code coverage report

Total: 28.95%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprroved.

@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:58 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Feb 12, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:59 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 12, 2025 10:59 — with GitHub Actions Inactive
@Innavin369 Innavin369 enabled auto-merge (squash) February 13, 2025 09:06
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:10 — with GitHub Actions Inactive
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a question.

@Innavin369 Innavin369 disabled auto-merge February 13, 2025 09:14
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:15 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:15 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:16 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment February 13, 2025 09:17 — with GitHub Actions Inactive
Copy link
Contributor

@vladsha-dev vladsha-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants