[OSDEV-1697] Redirect to the main page from close dialog button by VadimKovalenkoSNF · Pull Request #508 · opensupplyhub/open-supply-hub

VadimKovalenkoSNF · 2025-02-11T11:38:35Z

Apply redirect to the main page from close dialog button.
Apply redirect to the beginning of SLC flow (contribute/single-location?tab=os-id) when click browser's back button.

coderabbitai · 2025-02-11T11:40:55Z

Warning

Rate limit exceeded

@VadimKovalenkoSNF has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e653f53 and d0123b3.

📒 Files selected for processing (5)

doc/release/RELEASE-NOTES.md (1 hunks)
src/react/src/__tests__/components/ProductionLocationDialog.test.js (2 hunks)
src/react/src/components/Contribute/ProductionLocationDialog.jsx (5 hunks)
src/react/src/components/Contribute/ProductionLocationDialogCloseButton.jsx (2 hunks)
src/react/src/components/Contribute/ProductionLocationInfo.jsx (0 hunks)

📝 Walkthrough

Walkthrough

This pull request updates the release notes and modifies several React components handling the production location dialog. It adds a specific bug fix entry in the release notes for OSDEV-1697 and adjusts the dialog’s control flow. The changes remove the handleShow prop in favor of a new handleGoToMainPage function used during dialog closure. The modifications update related prop types and remove the state update function previously passed from the parent component, thereby altering how the dialog’s closure behavior triggers navigation to the main page.

Changes

File(s)	Change Summary
`doc/release/RELEASE-NOTES.md`	Added a detailed bug fix entry for release 2.0.0 addressing OSDEV-1697; replaced the generic placeholder with specific redirection behavior upon closing the SLC modal.
`src/react/.../ProductionLocationDialog.jsx`, `src/react/.../ProductionLocationDialogCloseButton.jsx`, `src/react/.../ProductionLocationInfo.jsx`	Removed the `handleShow` prop and replaced it with `handleGoToMainPage`; updated the onClick actions and prop types in dialog components; removed the direct state update function from `ProductionLocationInfo` for controlling dialog visibility.
`src/react/.../ProductionLocationDialog.test.js`	Updated test suite to remove `useHistory` mock; changed test case to verify redirection to the main page upon clicking the close button; simplified test structure by removing unnecessary complexity.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CLB as ProductionLocationDialogCloseButton
    participant Router as Main Page Router

    U->>CLB: Click close button
    CLB->>Router: Invoke handleGoToMainPage()
    Router-->>U: Navigate to main page

Suggested reviewers

Innavin369
vladsha-dev
roman-stolar
mazursasha1990

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

barecheck · 2025-02-11T11:45:35Z

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

barecheck · 2025-02-11T11:46:20Z

Contricleaner App | Unittest test suite - Code coverage report

Total: 98.91%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

barecheck · 2025-02-11T11:46:40Z

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

…ple-moderation-events

roman-stolar

LGTM

…ple-moderation-events

mazursasha1990

In general, looks good.
Left comments about improvements.

src/react/src/components/Contribute/ProductionLocationDialogCloseButton.jsx

…ple-moderation-events

mazursasha1990

LGTM

…ple-moderation-events

sonarqubecloud · 2025-02-13T09:06:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mazursasha1990

LGTM

Redirect to the main page from close button

e769830

VadimKovalenkoSNF self-assigned this Feb 11, 2025

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:38 — with GitHub Actions Inactive

VadimKovalenkoSNF had a problem deploying to Quality Environment February 11, 2025 11:38 — with GitHub Actions Failure

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:38 — with GitHub Actions Inactive

VadimKovalenkoSNF had a problem deploying to Quality Environment February 11, 2025 11:38 — with GitHub Actions Failure

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:38 — with GitHub Actions Inactive

VadimKovalenkoSNF had a problem deploying to Quality Environment February 11, 2025 11:38 — with GitHub Actions Failure

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:38 — with GitHub Actions Inactive

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:45 — with GitHub Actions Inactive

VadimKovalenkoSNF temporarily deployed to Quality Environment February 11, 2025 11:46 — with GitHub Actions Inactive

Override browser go back button when modal dialog is open

72ae812

VadimKovalenkoSNF temporarily deployed to Quality Environment February 12, 2025 07:42 — with GitHub Actions Inactive

VadimKovalenkoSNF temporarily deployed to Quality Environment February 12, 2025 09:05 — with GitHub Actions Inactive

VadimKovalenkoSNF had a problem deploying to Quality Environment February 12, 2025 09:05 — with GitHub Actions Failure

VadimKovalenkoSNF temporarily deployed to Quality Environment February 12, 2025 09:05 — with GitHub Actions Inactive

VadimKovalenkoSNF temporarily deployed to Quality Environment February 12, 2025 09:06 — with GitHub Actions Inactive

VadimKovalenkoSNF temporarily deployed to Quality Environment February 12, 2025 09:08 — with GitHub Actions Inactive

VadimKovalenkoSNF and others added 3 commits February 12, 2025 13:42

Merge branch 'main' into OSDEV-1697-protect-against-creation-of-multi…

c628e3e

…ple-moderation-events

Minor renaming

4197480

Merge branch 'main' into OSDEV-1697-protect-against-creation-of-multi…

e653f53

…ple-moderation-events

roman-stolar previously approved these changes Feb 12, 2025

View reviewed changes

Merge branch 'main' into OSDEV-1697-protect-against-creation-of-multi…

2b9d865

…ple-moderation-events

mazursasha1990 suggested changes Feb 12, 2025

View reviewed changes

src/react/src/components/Contribute/ProductionLocationDialogCloseButton.jsx Outdated Show resolved Hide resolved

src/react/src/components/Contribute/ProductionLocationDialogCloseButton.jsx Outdated Show resolved Hide resolved

VadimKovalenkoSNF and others added 2 commits February 13, 2025 12:15

Merge branch 'main' into OSDEV-1697-protect-against-creation-of-multi…

15d222c

…ple-moderation-events

Omtimize handleGoToMainPage invocation

0afa47f

mazursasha1990 previously approved these changes Feb 13, 2025

View reviewed changes

Merge branch 'main' into OSDEV-1697-protect-against-creation-of-multi…

d0123b3

…ple-moderation-events

mazursasha1990 approved these changes Feb 13, 2025

View reviewed changes

vladsha-dev approved these changes Feb 13, 2025

View reviewed changes

coderabbitai bot mentioned this pull request Feb 13, 2025

[OSDEV-1698] Fix link for submit another location button #505

Merged

coderabbitai bot mentioned this pull request Feb 24, 2025

[OSDEV-1777] Make the URL style consistent for all routes of the SLC workflow. #533

Merged

Conversation

VadimKovalenkoSNF commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

barecheck bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dedupe Hub App | Unittest test suite - Code coverage report

Uh oh!

barecheck bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contricleaner App | Unittest test suite - Code coverage report

Uh oh!

barecheck bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Countries App | Unittest test suite - Code coverage report

Uh oh!

roman-stolar left a comment

Choose a reason for hiding this comment

Uh oh!

mazursasha1990 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mazursasha1990 left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 13, 2025

Quality Gate passed

Uh oh!

mazursasha1990 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VadimKovalenkoSNF commented Feb 11, 2025 •

edited

Loading

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

barecheck bot commented Feb 11, 2025 •

edited

Loading

barecheck bot commented Feb 11, 2025 •

edited

Loading

barecheck bot commented Feb 11, 2025 •

edited

Loading