Skip to content

[OSDEV-1556] Fix validation of os_id during updating production location via moderation event.#475

Merged
mazursasha1990 merged 6 commits intomainfrom
OSDEV-1556-fix-validation-of-os-id-during-updating-production-location-via-moderation-event
Jan 6, 2025
Merged

[OSDEV-1556] Fix validation of os_id during updating production location via moderation event.#475
mazursasha1990 merged 6 commits intomainfrom
OSDEV-1556-fix-validation-of-os-id-during-updating-production-location-via-moderation-event

Conversation

@mazursasha1990
Copy link
Contributor

@mazursasha1990 mazursasha1990 commented Jan 3, 2025

OSDEV-1556 - Moderation Queue: PATCH: /api/v1/moderation-events/{moderation_id}/production-locations/{os_id}: Error 500 if os_id doesn't exist

The validation of os_id for the PATCH /api/v1/moderation-events/{moderation_id}/production-locations/{os_id}/ endpoint was fixed.

@mazursasha1990 mazursasha1990 self-assigned this Jan 3, 2025
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:38 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:40 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Jan 3, 2025

React App | Jest test suite - Code coverage report

Total: 27.85%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:45 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Jan 3, 2025

Dedupe Hub App | Unittest test suite - Code coverage report

Total: 56.14%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 3, 2025 14:45 — with GitHub Actions Inactive
@barecheck
Copy link

barecheck bot commented Jan 3, 2025

Countries App | Unittest test suite - Code coverage report

Total: 100%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

roman-stolar
roman-stolar previously approved these changes Jan 6, 2025
Copy link
Contributor

@roman-stolar roman-stolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@mazursasha1990 mazursasha1990 temporarily deployed to Quality Environment January 6, 2025 11:35 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

@mazursasha1990 mazursasha1990 merged commit e842dd5 into main Jan 6, 2025
@mazursasha1990 mazursasha1990 deleted the OSDEV-1556-fix-validation-of-os-id-during-updating-production-location-via-moderation-event branch January 6, 2025 12:07
protsack-stephan pushed a commit that referenced this pull request Apr 12, 2025
…ion via moderation event. (#475)

[OSDEV-1556](https://opensupplyhub.atlassian.net/browse/OSDEV-1556) -
Moderation Queue: PATCH:
/api/v1/moderation-events/{moderation_id}/production-locations/{os_id}:
Error 500 if os_id doesn't exist

The validation of `os_id` for the PATCH
`/api/v1/moderation-events/{moderation_id}/production-locations/{os_id}/`
endpoint was fixed.

[OSDEV-1556]:
https://opensupplyhub.atlassian.net/browse/OSDEV-1556?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants