Increase open search version from 2.13 to 2.17#383
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Docker
participant OpenSearch
participant Logstash
participant Database
participant Kafka
participant InitKafka
User->>Docker: Start services
Docker->>OpenSearch: Start opensearch-single-node
Docker->>Database: Start database
Docker->>Kafka: Start kafka
Kafka->>Docker: Health check
Docker->>Logstash: Start logstash
Logstash->>OpenSearch: Connects
Docker->>InitKafka: Start init-kafka
InitKafka->>Kafka: Create topics
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
React App | Jest test suite - Code coverage reportTotal: 25.86%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
docker-compose.yml (1)
227-227: LGTM: Added LOG_LEVEL environment variable.Adding the
LOG_LEVEL=INFOenvironment variable is a good practice for controlling log verbosity in the Logstash service.Consider adding a comment explaining the purpose of this variable for better documentation:
- LOGSTASH_UPDATE_INTERVAL_MINUTES=1 + # Control the verbosity of Logstash logs - LOG_LEVEL=INFO
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- docker-compose.yml (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
docker-compose.yml (2)
Line range hint
229-231: LGTM: Adjusted service dependencies for Logstash.The
depends_onsection for thelogstashservice has been correctly adjusted to include bothopensearch-single-nodeanddatabase. This ensures proper service startup order.
Line range hint
1-234: Summary: OpenSearch version updated and Logstash configuration improved.The changes in this PR successfully achieve the objective of updating the OpenSearch version from 2.13 to 2.17. Additionally, the Logstash service configuration has been improved with better log level control and proper service dependencies.
These changes enhance the overall Docker Compose configuration without introducing any apparent conflicts or issues with other services.
Django App | Unittest test suite - Code coverage reportTotal: 77.93%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Not sure about risks. I consider them as low, but if we merge now, we have plenty time to test |
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
docker-compose.yml (2)
Line range hint 187-204: Consider adding health check for OpenSearch
While the OpenSearch configuration is correct, adding a health check would ensure more robust service startup orchestration, especially since other services depend on it.
Add the following health check configuration:
image: opensearchproject/opensearch:2.17.0
+ healthcheck:
+ test: ["CMD-SHELL", "curl -s http://localhost:9200/_cluster/health?pretty | grep -q '\"status\" : \"green\"\\|\"status\" : \"yellow\"'"]
+ interval: 20s
+ timeout: 10s
+ retries: 3
environment:Line range hint 191-192: Review Resource Allocation for Production
The JVM heap size is set to 512MB (min and max), which might need adjustment based on your production workload and available resources.
Consider:
- Adjusting
OPENSEARCH_JAVA_OPTSbased on available system memory (recommended: 50% of system RAM) - Monitoring memory usage patterns to optimize these settings
- Implementing horizontal scaling if needed
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- doc/release/RELEASE-NOTES.md (1 hunks)
- docker-compose.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- doc/release/RELEASE-NOTES.md
🔇 Additional comments (2)
docker-compose.yml (2)
187-187: OpenSearch version upgrade looks good!
The upgrade to OpenSearch 2.17.0 is correctly implemented. The configuration settings, including memory limits, security settings, and resource limits, are properly configured for the new version.
Line range hint 193-195: Security Configuration Advisory
The current configuration disables the security plugin and demo configurations, which is fine for development. However, ensure that appropriate security measures are implemented in production environments.
Consider maintaining separate configuration files for development and production environments, with security properly enabled in production.



This pr increases Open Search version from 2.13 to 2.17 because 2.13 image has been abandoned and isn't maintained anymore