[OSDEV-1778] Fix the validation for number of workers field in POST, PATCH production locations API#44
Merged
Innavin369 merged 3 commits intomainfrom Feb 27, 2025
Conversation
Innavin369
requested review from
VadimKovalenkoSNF,
mazursasha1990,
roman-stolar and
vladsha-dev
VadimKovalenkoSNF
approved these changes
Feb 26, 2025
vladsha-dev
changed the title
vladsha-dev
suggested changes
Feb 26, 2025
Contributor
There was a problem hiding this comment.
Could you please update the minimum values for the min and max fields in the number_of_workers field?
See the following files:
open-supply-hub-api-docs/docs/schemas/cleaned_data_fields.jsonopen-supply-hub-api-docs/docs/schemas/cleaned_data_raw_json.json
I believe the minimum values should be the same as in the file you edited.
Innavin369
added a commit
to opensupplyhub/open-supply-hub
that referenced
this pull request
Feb 27, 2025
…, PATCH production locations API (#532) [OSDEV-1778](https://opensupplyhub.atlassian.net/browse/OSDEV-1778) Fix the validation for `number_of_workers` field in POST, PATCH production locations API. * min can be less or equal to max * min and max must be integer * fixed [API spec](https://opensupplyhub.github.io/open-supply-hub-api-docs/) in [the PR](opensupplyhub/open-supply-hub-api-docs#44) [OSDEV-1778]: https://opensupplyhub.atlassian.net/browse/OSDEV-1778?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Inessa Druzhkova <[email protected]>
protsack-stephan
pushed a commit
to opensupplyhub/open-supply-hub
that referenced
this pull request
Apr 12, 2025
…, PATCH production locations API (#532) [OSDEV-1778](https://opensupplyhub.atlassian.net/browse/OSDEV-1778) Fix the validation for `number_of_workers` field in POST, PATCH production locations API. * min can be less or equal to max * min and max must be integer * fixed [API spec](https://opensupplyhub.github.io/open-supply-hub-api-docs/) in [the PR](opensupplyhub/open-supply-hub-api-docs#44) [OSDEV-1778]: https://opensupplyhub.atlassian.net/browse/OSDEV-1778?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Inessa Druzhkova <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OSDEV-1778 Fix the validation for the number_of_workers field in POST, PATCH production locations API: