fix: trim mcp command and url

[erha19]

Types

• 🐛 Bug Fixes

Background or solution

部分场景下，空格可能导致异常

Changelog

trim mcp command and url

Summary by CodeRabbit

• 优化
  • 提交表单时，自动去除命令和 URL 字段的首尾空格，提升数据准确性。

[coderabbitai]

Walkthrough

本次更改在表单数据保存前，明确对 command 和 url 字段进行了去除首尾空白字符的处理。无论服务器类型如何，只要这两个字段存在，都会被修剪。这一处理发生在表单校验之后、参数和环境变量进一步处理之前。

Changes

文件路径	变更摘要
packages/ai-native/src/browser/mcp/config/components/mcp-server-form.tsx	在保存表单数据前，对 command 和 url 字段进行了统一的去空白处理。

Suggested labels

🐞 bug

Suggested reviewers

• hacke2
• ensorrow

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/ai-native/src/browser/mcp/config/components/mcp-server-form.tsx (1)

115-117: 存在冗余的 URL 去空白处理

当服务器类型为 SSE 时，url 字段会被重复处理两次：一次在第 113 行无条件处理，另一次在第 116 行条件处理。这会导致不必要的重复操作。

建议简化这部分代码，避免重复处理：

  if (form.command) {
    form.command = form.command.trim();
  }
  if (form.url) {
    form.url = form.url.trim();
  }
  if (formData.type === MCP_SERVER_TYPE.SSE) {
-   form.url = form.url?.trim();
  } else {
    const args = argsText.split(' ').filter(Boolean);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6cb941 and dbb42ba.

📒 Files selected for processing (1)

• packages/ai-native/src/browser/mcp/config/components/mcp-server-form.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: ubuntu-latest, Node.js 20.x
• GitHub Check: build (macos-latest, 20.x)
• GitHub Check: build (ubuntu-latest, 20.x)
• GitHub Check: build-windows

🔇 Additional comments (1)

packages/ai-native/src/browser/mcp/config/components/mcp-server-form.tsx (1)

109-114: 修复空白字符引起的问题，代码逻辑清晰

这个修改很好地解决了空白字符可能导致的异常问题。通过在保存前对 command 和 url 字段进行去除首尾空白的处理，可以有效防止因空格引起的错误。代码逻辑清晰，确保了只有在字段存在时才进行处理。

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.87%. Comparing base (e6cb941) to head (dbb42ba).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4557   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files        1677     1677           
  Lines      103378   103378           
  Branches    22391    22383    -8     
=======================================
+ Hits        54661    54665    +4     
+ Misses      40532    40528    -4     
  Partials     8185     8185           

Flag	Coverage Δ
jsdom	48.38% <ø> (+<0.01%)	⬆️
node	12.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.