fix: remove prefix of builtin tools

[ensorrow]

Types

• 🐛 Bug Fixes

Background or solution

fix: remove prefix of builtin tools

Changelog

fix: remove prefix of builtin tools

Summary by CodeRabbit

• 新功能
  • 工具名称的显示方式进行了优化，根据不同服务器类型，名称格式将有所区别。

[ensorrow]

/next

[coderabbitai]

Walkthrough

本次更改调整了getToolName函数的参数和逻辑。该函数现在要求显式传递toolName和serverName两个参数，并根据serverName的值决定返回格式。默认参数被移除，且当serverName为内置值时返回仅为toolName。

Changes

文件路径	变更摘要
packages/ai-native/src/common/utils.ts	修改了getToolName函数签名，移除了默认参数，调整了返回逻辑。

Sequence Diagram(s)

sequenceDiagram
    participant 调用者
    participant utils.ts

    调用者->>utils.ts: getToolName(toolName, serverName)
    alt serverName 等于 BUILTIN_MCP_SERVER_NAME
        utils.ts-->>调用者: 返回 toolName
    else
        utils.ts-->>调用者: 返回 "mcp_${serverName}_${toolName}"
    end

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b838b53 and e36b7f0.

📒 Files selected for processing (1)

• packages/ai-native/src/common/utils.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/ai-native/src/common/utils.ts (1)

packages/ai-native/src/common/index.ts (1)

• BUILTIN_MCP_SERVER_NAME (40-40)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: 🚀🚀🚀 Next Version for pull request
• GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
• GitHub Check: unittest (ubuntu-latest, 18.x, node)
• GitHub Check: unittest (macos-latest, 18.x, jsdom)
• GitHub Check: unittest (macos-latest, 18.x, node)
• GitHub Check: ubuntu-latest, Node.js 20.x
• GitHub Check: build (ubuntu-latest, 20.x)
• GitHub Check: build-windows
• GitHub Check: build (macos-latest, 20.x)

🔇 Additional comments (1)

packages/ai-native/src/common/utils.ts (1)

54-55:

Details

✅ Verification successful

函数签名变更和行为调整

此变更调整了getToolName函数的参数和返回逻辑：

1. 移除了serverName参数的默认值，现在需要显式传递
2. 增加了条件判断：当serverName为内置服务器时，直接返回toolName不添加前缀

这个变更符合PR的目标"移除内置工具的前缀"，但需要注意以下几点：

1. 函数签名变更可能会影响现有调用代码，确保所有调用处都已更新
2. 请确认此改动不会破坏依赖工具名称格式的其他功能

---

🏁 Script executed:

#!/bin/bash
# 查找所有调用getToolName函数的地方，验证调用方式是否都已更新
echo "查找getToolName函数的调用点..."
rg "getToolName\(" --type ts

Length of output: 563

---

已验证所有 getToolName 调用点

• packages/ai-native/src/node/mcp-server-manager-impl.ts：getToolName(tool.name, serverName)
• packages/ai-native/src/browser/mcp/mcp-server.feature.registry.ts：
  • getToolName(tool.name, serverName) === name
  • this.toolComponents[getToolName(name, serverName)] = component

所有调用均已显式传入 serverName，函数签名变更不会影响现有调用，无需额外修改。

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[opensumi]

🎉 PR Next publish successful!

3.8.3-next-1747128777.0

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (b838b53) to head (e36b7f0).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/ai-native/src/common/utils.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4546      +/-   ##
==========================================
- Coverage   52.88%   52.88%   -0.01%     
==========================================
  Files        1677     1677              
  Lines      103358   103359       +1     
  Branches    22391    22383       -8     
==========================================
- Hits        54662    54657       -5     
- Misses      40516    40521       +5     
- Partials     8180     8181       +1     

Flag	Coverage Δ
jsdom	48.38% <50.00%> (-0.01%)	⬇️
node	12.06% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.