Skip to content

fix: sse mcp esm module#4473

Merged
wangxiaojuan merged 1 commit intomainfrom
fix/mcp-sse-module
Mar 12, 2025
Merged

fix: sse mcp esm module#4473
wangxiaojuan merged 1 commit intomainfrom
fix/mcp-sse-module

Conversation

@Ricbet
Copy link
Copy Markdown
Member

@Ricbet Ricbet commented Mar 12, 2025

Types

  • 🎉 New Features
  • 🐛 Bug Fixes
  • 📚 Documentation Changes
  • 💄 Code Style Changes
  • 💄 Style Changes
  • 🪚 Refactors
  • 🚀 Performance Improvements
  • 🏗️ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

Changelog

Summary by CodeRabbit

  • 重构
    • 优化了加载流程,现在部分资源将在启动时按需加载,从而提升启动效率和系统资源管理。此更新仅优化内部机制,用户的使用体验和现有功能保持不变。

@Ricbet
Copy link
Copy Markdown
Member Author

Ricbet commented Mar 12, 2025

/next

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Mar 12, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2025

Walkthrough

此次修改将 SSEClientTransport 的静态导入更改为在 SSEMCPServer 类的 start 方法中使用动态导入。模块在加载时不再预先加载 SSEClientTransport,而是在执行 start 方法时异步加载该模块。整体控制流程保持基本不变,仅调整了导入的时机。

Changes

文件 修改摘要
packages/ai-native/.../mcp-server.sse.ts SSEClientTransport 的静态导入替换为在 start 方法中的动态导入。

Sequence Diagram(s)

sequenceDiagram
    participant Client as 客户端
    participant Server as SSEMCPServer
    participant Module as SSEClientTransport模块

    Client->>Server: 调用 start 方法
    Server->>Module: 动态 import '.../sse.js'
    Module-->>Server: 返回 SSEClientTransport
    Server->>Module: 实例化 SSEClientTransport
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cbd37c and d44d422.

📒 Files selected for processing (1)
  • packages/ai-native/src/node/mcp-server.sse.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: 🚀🚀🚀 Next Version for pull request
  • GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
  • GitHub Check: build (ubuntu-latest, 20.x)
  • GitHub Check: unittest (ubuntu-latest, 18.x, node)
  • GitHub Check: build (macos-latest, 20.x)
  • GitHub Check: unittest (macos-latest, 18.x, jsdom)
  • GitHub Check: ubuntu-latest, Node.js 20.x
  • GitHub Check: build-windows
🔇 Additional comments (1)
packages/ai-native/src/node/mcp-server.sse.ts (1)

36-37: 优化了 SSEClientTransport 的导入方式

将静态导入改为动态导入是一个很好的改进。这样可以避免在模块加载时就预先加载 SSEClientTransport,而是在实际需要时(执行 start 方法时)才进行异步加载。这种懒加载方式有以下好处:

  1. 减少初始加载时间和内存占用
  2. 解决了可能存在的 ESM 模块循环依赖问题
  3. 提高了代码的可维护性

这种修改与 PR 标题 "fix: sse mcp esm module" 所述的目的一致,解决了 ESM 模块相关的问题。

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Mar 12, 2025

🎉 PR Next publish successful!

3.8.3-next-1741769321.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.24%. Comparing base (1cbd37c) to head (d44d422).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4473   +/-   ##
=======================================
  Coverage   53.23%   53.24%           
=======================================
  Files        1663     1663           
  Lines      102619   102619           
  Branches    22201    22201           
=======================================
+ Hits        54632    54640    +8     
+ Misses      39926    39921    -5     
+ Partials     8061     8058    -3     
Flag Coverage Δ
jsdom 48.73% <0.00%> (+<0.01%) ⬆️
node 12.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wangxiaojuan wangxiaojuan merged commit ffa0303 into main Mar 12, 2025
@wangxiaojuan wangxiaojuan deleted the fix/mcp-sse-module branch March 12, 2025 09:33
@erha19 erha19 mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants