Skip to content

feat: add user's intention in apply prompt#4454

Merged
Aaaaash merged 3 commits intomainfrom
fix/edit-instruction
Mar 8, 2025
Merged

feat: add user's intention in apply prompt#4454
Aaaaash merged 3 commits intomainfrom
fix/edit-instruction

Conversation

@ensorrow
Copy link
Copy Markdown
Contributor

@ensorrow ensorrow commented Mar 8, 2025

Types

  • 🎉 New Features

Background or solution

feat: add user's intention in apply prompt

Changelog

feat: add user's intention in apply prompt

Summary by CodeRabbit

  • 新功能
    • 用户现在可以在提交请求时附加额外说明,帮助 AI 服务获得更详尽的上下文信息,从而提升响应的精准性和效果。
    • registerCodeBlock 方法现在支持可选的说明参数,允许在注册代码块时包含额外的说明信息。
    • EditFileHandler 的处理方法现在可以接收并传递附加的说明参数。

@ensorrow ensorrow requested review from Aaaaash and erha19 March 8, 2025 04:29
@opensumi opensumi Bot added the 🎨 feature feature required label Mar 8, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 8, 2025

Walkthrough

此次变更在多个模块中引入了对用户指令的支持。具体来说,在 chat 模块中,构造请求时会根据条件附加用户意图的说明;在 mcp 模块中,更新了 registerCodeBlock 方法和文件编辑处理器以接收可选的 instructions 参数,从而将额外指令传递给后续流程。同时在获取诊断信息处新增了待重构的提示注释。

Changes

文件 变更摘要
packages/ai-native/.../chat/apply.service.ts 增加条件性字符串插值:当存在 codeBlock.instructions 时,在请求中附加 "User's intention: [instructions]"
packages/ai-native/.../mcp/base-apply.service.ts
packages/ai-native/.../handlers/EditFile.ts
修改 registerCodeBlock 方法和 EditFileHandlerhandler 方法,添加可选参数 instructions 并将其传递,同时在 getDiagnosticInfos 方法处添加重构提示注释。

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant EF as EditFileHandler
    participant BA as BaseApplyService
    participant CA as ChatApplyService
    participant AI as AI后端

    U->>EF: 发起编辑文件请求 (targetFile, codeEdit, instructions?)
    EF->>BA: 调用 registerCodeBlock(targetFile, codeEdit, toolCallId, instructions?)
    BA-->>EF: 返回 CodeBlockData
    EF->>CA: 生成并发送AI请求 (包含条件性插值)
    CA->>AI: 请求处理代码更新 (附带 "User's intention: [instructions]?" )
    AI-->>CA: 返回处理结果
    CA-->>EF: 返回AI响应
    EF-->>U: 返回最终处理结果
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cef521 and 93f4703.

📒 Files selected for processing (1)
  • packages/ai-native/src/browser/mcp/base-apply.service.ts (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ai-native/src/browser/mcp/base-apply.service.ts
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
  • GitHub Check: unittest (ubuntu-latest, 18.x, node)
  • GitHub Check: build (ubuntu-latest, 20.x)
  • GitHub Check: build (macos-latest, 20.x)
  • GitHub Check: unittest (macos-latest, 18.x, jsdom)
  • GitHub Check: ubuntu-latest, Node.js 20.x
  • GitHub Check: unittest (macos-latest, 18.x, node)
  • GitHub Check: build-windows

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (30c372d) to head (93f4703).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...es/ai-native/src/browser/mcp/base-apply.service.ts 0.00% 3 Missing ⚠️
...-native/src/browser/mcp/tools/handlers/EditFile.ts 0.00% 2 Missing ⚠️
...ckages/ai-native/src/browser/chat/apply.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4454      +/-   ##
==========================================
- Coverage   53.27%   53.27%   -0.01%     
==========================================
  Files        1661     1661              
  Lines      102534   102535       +1     
  Branches    22179    22180       +1     
==========================================
- Hits        54627    54626       -1     
- Misses      39859    39860       +1     
- Partials     8048     8049       +1     
Flag Coverage Δ
jsdom 48.76% <0.00%> (-0.01%) ⬇️
node 12.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aaaaash Aaaaash merged commit 7cfc321 into main Mar 8, 2025
@Aaaaash Aaaaash deleted the fix/edit-instruction branch March 8, 2025 07:04
@ensorrow ensorrow restored the fix/edit-instruction branch March 8, 2025 07:08
@erha19 erha19 mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants