fix: debug stop render

[Ricbet]

Types

• 🐛 Bug Fixes

Background or solution

Changelog

修复 debug 的停止按钮不可用的问题

Summary by CodeRabbit

• 新功能
  • 更新了调试工具栏的停止和继续操作的启用逻辑。
  • 改进了会话选择事件的处理方式。

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning eslint@8.57.1: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/config-array@0.13.0: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > glob@7.2.3: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

变更概述

步骤说明

此拉取请求修改了 debug-toolbar.view.tsx 文件中的 DebugToolbarView 组件。主要变更包括更新 renderStop 和 renderContinue 函数中的 enabled 属性的逻辑，并优化 setCurrentSession 函数以更健壮地处理事件参数。这些更改旨在改进调试工具栏的状态控制和会话选择机制。

变更

文件路径	变更概述
packages/debug/src/browser/view/configuration/debug-toolbar.view.tsx	- 修改 renderStop 和 renderContinue 方法的 enabled 状态逻辑 - 优化 setCurrentSession 方法的事件处理

可能相关的拉取请求

• fix: debug console enter invalid #4252：涉及 DebugConsoleContribution 类的更改，与调试功能相关

建议标签

🐞 bug

建议审阅者

• hacke2
• erha19
• ensorrow
• zhanba

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/debug/src/browser/view/configuration/debug-toolbar.view.tsx (1)

140-140: **可考虑复用逻辑或提升可读性 **

与上方相同，enabled={state !== DebugState.Inactive} 在不同分支内重复出现，可适度封装判断逻辑以提升可读性和可维护性。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89c4fea and 136ece9.

📒 Files selected for processing (1)

• packages/debug/src/browser/view/configuration/debug-toolbar.view.tsx (2 hunks)

🔇 Additional comments (1)

packages/debug/src/browser/view/configuration/debug-toolbar.view.tsx (1)

131-131: **请确认所有状态枚举均被正确处理 **

当前条件 enabled={state !== DebugState.Inactive} 能够覆盖大多数状态切换场景，但在后续可能新增其他状态或需要禁用此按钮时，需确保逻辑可拓展并且不会遗漏某些状态。

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.72%. Comparing base (89c4fea) to head (136ece9).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4264      +/-   ##
==========================================
- Coverage   53.72%   53.72%   -0.01%     
==========================================
  Files        1622     1622              
  Lines       98572    98572              
  Branches    20143    20151       +8     
==========================================
- Hits        52955    52953       -2     
- Misses      37911    37912       +1     
- Partials     7706     7707       +1     

Flag	Coverage Δ
jsdom	49.19% <ø> (-0.01%)	⬇️
node	15.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hacke2]

LGTM