Skip to content

fix: potential null ref when reloading components#4228

Merged
hacke2 merged 2 commits into
opensumi:v3.6from
hacke2:fix/check-ref
Dec 16, 2024
Merged

fix: potential null ref when reloading components#4228
hacke2 merged 2 commits into
opensumi:v3.6from
hacke2:fix/check-ref

Conversation

@hacke2
Copy link
Copy Markdown
Member

@hacke2 hacke2 commented Dec 13, 2024

Types

  • 🐛 Bug Fixes

Background or solution

image

组件重新渲染时会出错

Changelog

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Dec 13, 2024
@hacke2 hacke2 requested a review from Ricbet December 13, 2024 07:50
@hacke2
Copy link
Copy Markdown
Member Author

hacke2 commented Dec 13, 2024

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Dec 13, 2024

🎉 PR Next publish successful!

3.6.1-next-1734076438.0

@hacke2
Copy link
Copy Markdown
Member Author

hacke2 commented Dec 13, 2024

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Dec 13, 2024

🎉 PR Next publish successful!

3.6.2-next-1734078245.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 13, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.06%. Comparing base (ca15b4c) to head (6783acc).
⚠️ Report is 13 commits behind head on v3.6.

Additional details and impacted files
@@            Coverage Diff             @@
##             v3.6    #4228      +/-   ##
==========================================
- Coverage   54.18%   54.06%   -0.12%     
==========================================
  Files        1616     1616              
  Lines       99701    97965    -1736     
  Branches    20596    20047     -549     
==========================================
- Hits        54021    52964    -1057     
+ Misses      37832    37392     -440     
+ Partials     7848     7609     -239     
Flag Coverage Δ
jsdom 49.64% <ø> (-0.19%) ⬇️
node 15.55% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hacke2 hacke2 merged commit ec675f6 into opensumi:v3.6 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants