Skip to content

fix: add keyboard focus and accessibility support for editor tabs and close buttons#3957

Merged
bytemain merged 1 commit intoopensumi:mainfrom
lilangtop:fix/edit-tab/accessiblity
Aug 21, 2024
Merged

fix: add keyboard focus and accessibility support for editor tabs and close buttons#3957
bytemain merged 1 commit intoopensumi:mainfrom
lilangtop:fix/edit-tab/accessiblity

Conversation

@lilangtop
Copy link
Copy Markdown
Contributor

@lilangtop lilangtop commented Aug 20, 2024

Types

  • 🐛 Bug Fixes

Background or solution

为编辑器的tab和关闭按钮添加键盘焦点和无障碍属性支持,tab和关闭按钮支持键盘聚焦,屏幕阅读器朗读,选中的tab有选中提示。
编辑器代码解释

Changelog

Summary by CodeRabbit

  • 新功能
    • 增强了标签组件的可访问性,支持屏幕阅读器。
    • 添加了ARIA角色和属性,改善用户体验。
    • 更新了关闭按钮的可访问性,提供本地化描述。

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Aug 20, 2024
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 20, 2024

Walkthrough

此次更改主要增强了Tabs组件的可访问性和语义性。通过添加ARIA角色和属性,提升了屏幕阅读器的支持以及整体用户体验。更改包括使资源名称的div元素可聚焦,并为关闭按钮提供了本地化描述,以便辅助技术用户更有效地导航和交互。

Changes

文件 更改摘要
.../tab.view.tsx 增强了Tabs组件的可访问性,添加ARIA角色和属性,包括role='tab'aria-selected,使元素可聚焦并提供更好的辅助技术支持。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Tabs
    participant ScreenReader

    User->>Tabs: 聚焦在标签
    Tabs->>ScreenReader: 提供当前标签状态和可用操作
    User->>Tabs: 选择关闭按钮
    Tabs->>ScreenReader: 更新标签状态并通知关闭操作
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.88%. Comparing base (b127cf9) to head (dcd471a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3957   +/-   ##
=======================================
  Coverage   54.88%   54.88%           
=======================================
  Files        1566     1566           
  Lines       95564    95564           
  Branches    19591    19599    +8     
=======================================
  Hits        52453    52453           
  Misses      35793    35793           
  Partials     7318     7318           
Flag Coverage Δ
jsdom 50.34% <ø> (ø)
node 15.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit 522aee9 into opensumi:main Aug 21, 2024
Ricbet pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants