Skip to content

fix: enable multi-root workspace support#3848

Merged
zhanba merged 2 commits intoopensumi:mainfrom
zhanba:fix-debug-console
Jul 18, 2024
Merged

fix: enable multi-root workspace support#3848
zhanba merged 2 commits intoopensumi:mainfrom
zhanba:fix-debug-console

Conversation

@zhanba
Copy link
Copy Markdown
Contributor

@zhanba zhanba commented Jul 12, 2024

Types

  • 🎉 New Features

Background or solution

开启以下配置的情况下

  opts.defaultPreferences = {
    'workspace.supportMultiRootWorkspace': true,
    'application.supportsOpenFolder': true,
    'application.supportsOpenWorkspace': true,
  };
  • 支持打开文件夹和打开.sumi-workspace工作区
    image

  • 支持添加文件夹和删除文件夹
    image

image

Changelog

Summary by CodeRabbit

  • 新功能

    • 增加了工作区文件和文件夹相关的新命令。
    • 增加了终端选择当前工作目录的新功能。
  • 错误修复

    • 修复了文件选择对话框的文件过滤逻辑问题。
  • 改进

    • 更新了“多根工作区支持”偏好的描述。
    • 改进了终端和文件操作的本地化字符串。
  • 本地化

    • 更新了简体中文和英语的本地化字符串,以提高文本的清晰度和功能性。

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 12, 2024

Walkthrough

此次更新涵盖了多个部分,包括VSCode扩展配置、文件树和对话框逻辑、终端功能、多根工作区支持以及国际化文本优化。主要改进包括引入新的工作区管理命令、调整文件对话框的过滤逻辑、增强终端目录选择功能,并改进了多根工作区的支持和相关文档描述。

Changes

文件路径 变更摘要
configs/vscode-extensions.json 更新了 ms-python 扩展的版本。
packages/core-browser/src/common/common.command.ts REMOVE_WORKSPACE_FOLDER 命令添加了 label 字段。
packages/core-browser/src/common/common.contribution.ts 添加了与工作区文件相关的新命令。
packages/file-tree-next/src/browser/dialog/file-dialog.view.tsx 调整了 FileDialog 组件的文件选择逻辑,增加了基于过滤器的文件选择。
packages/file-tree-next/src/browser/file-tree-contribution.ts 在菜单和命令注册中增加了与工作区文件夹相关的新项。
packages/i18n/src/common/en-US.lang.ts 修改了多个文件和终端操作的本地化字符串。
packages/i18n/src/common/zh-CN.lang.ts 优化了文件操作和终端操作的中文本地化字符串。
packages/overlay/src/common/index.ts 修改了 IDialogOptions 接口中 filters 属性的类型定义。
packages/terminal-next/src/browser/terminal.client.ts quickPick.show 方法调用添加了新的选项对象。
packages/terminal-next/src/browser/terminal.controller.ts 修改了方法调用的参数,增加了 falsetrue 参数。
packages/terminal-next/src/browser/terminal.view.ts Widget 类和 TerminalGroupViewService 类的构造函数和方法添加了 recovery 参数。
packages/terminal-next/src/common/resize.ts IWidget 接口中添加了 recovery 属性。
packages/workspace/src/browser/workspace-preferences.ts 修改了 workspace.supportMultiRootWorkspace 偏好的描述文本。
packages/workspace/src/common/mocks/workspace-service.ts 添加了 workspaceSuffixName 属性和新的 open 方法。
packages/workspace/src/common/workspace.interface.ts IWorkspaceService 接口中添加了 workspaceSuffixName 属性和 open 方法。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Jul 12, 2024
@zhanba
Copy link
Copy Markdown
Contributor Author

zhanba commented Jul 12, 2024

#3830

Comment thread packages/core-browser/src/window/window.service.ts Outdated
Comment thread packages/core-browser/src/window/window.service.ts Outdated
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment thread packages/workspace/src/common/mocks/workspace-service.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.99%. Comparing base (fe71646) to head (7709b93).

Files Patch % Lines
...kages/terminal-next/src/browser/terminal.client.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3848      +/-   ##
==========================================
- Coverage   54.99%   54.99%   -0.01%     
==========================================
  Files        1557     1557              
  Lines       94813    94814       +1     
  Branches    19401    19401              
==========================================
  Hits        52141    52141              
- Misses      35456    35457       +1     
  Partials     7216     7216              
Flag Coverage Δ
jsdom 50.42% <66.66%> (-0.01%) ⬇️
node 15.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet
Copy link
Copy Markdown
Member

Ricbet commented Jul 16, 2024

/next

@Ricbet
Copy link
Copy Markdown
Member

Ricbet commented Jul 16, 2024

检查一下 E2E

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jul 16, 2024

🎉 PR Next publish successful!

3.1.5-next-1721114299.0

@zhanba zhanba requested a review from erha19 July 17, 2024 06:50
Ricbet
Ricbet previously approved these changes Jul 17, 2024
Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/i18n/src/common/zh-CN.lang.ts Outdated
Comment thread packages/startup/entry/web/render-app.tsx Outdated
Comment thread packages/startup/entry/web/render-app.tsx Outdated
@zhanba zhanba requested a review from bytemain July 17, 2024 09:36
Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19
Copy link
Copy Markdown
Member

erha19 commented Jul 18, 2024

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jul 18, 2024

🎉 PR Next publish successful!

3.1.5-next-1721270303.0

@zhanba
Copy link
Copy Markdown
Contributor Author

zhanba commented Jul 18, 2024

🎉 PR Next publish successful!

3.1.5-next-1721270303.0

测试没问题

@zhanba zhanba merged commit d26c0ef into opensumi:main Jul 18, 2024
@zhanba zhanba deleted the fix-debug-console branch July 18, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants