Skip to content

fix: server's incorrect dispose of service center#3785

Merged
bytemain merged 6 commits intomainfrom
fix/connection-dispose
Jun 18, 2024
Merged

fix: server's incorrect dispose of service center#3785
bytemain merged 6 commits intomainfrom
fix/connection-dispose

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Jun 17, 2024

Types

  • 🐛 Bug Fixes

Background or solution

又梳理了一下重连会带来的一些问题

  1. rpc service center 和 channel 的 dispose 没有完全清理干净
  2. 新建 channel 没有删掉旧的, 旧 channel 仍然可以收到消息
  3. 重连会多次创建 Worker,导致通信很多报错
  4. EventQueue 逻辑有问题,当没有接收方的时候,没有存消息到队列中

Changelog

fix server's incorrect dispose of service center

@railway-app
Copy link
Copy Markdown

railway-app Bot commented Jun 17, 2024

🚅 Deployed to the core-pr-3785 environment in core

Service Status Web Updated (UTC)
core ◻️ Removed (View Logs) Web Jun 18, 2024 at 12:00 pm

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Jun 17, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 82.96296% with 23 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (240f439) to head (a7a69f6).
Report is 27 commits behind head on main.

Files Patch % Lines
.../extension/src/browser/extension-worker.service.ts 9.09% 10 Missing ⚠️
packages/connection/src/common/ws-channel.ts 90.76% 6 Missing ⚠️
...ckages/connection/src/common/rpc-service/center.ts 0.00% 2 Missing ⚠️
packages/connection/src/common/server-handler.ts 83.33% 2 Missing ⚠️
packages/core-node/src/connection.ts 0.00% 1 Missing ⚠️
.../terminal-next/src/node/terminal.service.client.ts 0.00% 1 Missing ⚠️
packages/utils/src/linked-list.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3785      +/-   ##
==========================================
- Coverage   55.32%   55.21%   -0.12%     
==========================================
  Files        1540     1544       +4     
  Lines       93895    94249     +354     
  Branches    19283    19339      +56     
==========================================
+ Hits        51949    52041      +92     
- Misses      34802    35035     +233     
- Partials     7144     7173      +29     
Flag Coverage Δ
jsdom 50.67% <54.81%> (-0.12%) ⬇️
node 15.56% <73.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Ricbet
Ricbet previously approved these changes Jun 18, 2024
@bytemain bytemain merged commit c5191c3 into main Jun 18, 2024
@bytemain bytemain deleted the fix/connection-dispose branch June 18, 2024 12:00
@bytemain
Copy link
Copy Markdown
Member Author

/backport

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jun 21, 2024

Cannot extract the target branch from /backport

Example: backport to v2.23

@bytemain
Copy link
Copy Markdown
Member Author

/backport v3.1

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jun 21, 2024

Backporting to v3.1 branch is started.
Please see: https://github.com/opensumi/actions/actions/workflows/backport-pr.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants