feat: prevent accidentally opening binary file#3772
Merged
Conversation
|
🚅 Previously deployed to Railway in the core project. Environment has been deleted. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
==========================================
- Coverage 55.36% 55.26% -0.11%
==========================================
Files 1541 1545 +4
Lines 93972 94209 +237
Branches 19292 19327 +35
==========================================
+ Hits 52026 52060 +34
- Misses 34806 34983 +177
- Partials 7140 7166 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ricbet
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
如果用户不小心点击了 node 的 binary 文件,我们原来的识别无法识别到它是一个二进制文件。
现在复用了检测二进制的逻辑(和 vscode 保持一致)
Changelog
prevent accidentally opening binary file