Skip to content

feat: add rpc timing event track#3743

Merged
Ricbet merged 5 commits intomainfrom
feat/add-rpc-event-track
Jun 6, 2024
Merged

feat: add rpc timing event track#3743
Ricbet merged 5 commits intomainfrom
feat/add-rpc-event-track

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Jun 5, 2024

Types

  • 🎉 New Features

Background or solution

增加 rpc 的埋点上报渠道

Changelog

add rpc timing event track

@railway-app railway-app Bot temporarily deployed to core-pr-3743 June 5, 2024 09:42 Destroyed
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Jun 5, 2024

🚅 Previously deployed to Railway in the core project. Environment has been deleted.

@opensumi opensumi Bot added the 🎨 feature feature required label Jun 5, 2024
@railway-app railway-app Bot temporarily deployed to core-pr-3743 June 5, 2024 09:44 Destroyed
hacke2
hacke2 previously approved these changes Jun 5, 2024
Copy link
Copy Markdown
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.36%. Comparing base (3aca27a) to head (cc4b2a6).

Files Patch % Lines
...ckages/connection/src/common/rpc-service/center.ts 41.66% 6 Missing and 1 partial ⚠️
packages/core-browser/src/bootstrap/connection.ts 50.00% 1 Missing and 1 partial ⚠️
packages/utils/src/functional.ts 0.00% 2 Missing ⚠️
packages/core-common/src/reporter.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3743   +/-   ##
=======================================
  Coverage   55.35%   55.36%           
=======================================
  Files        1537     1537           
  Lines       93828    93848   +20     
  Branches    19270    19284   +14     
=======================================
+ Hits        51942    51957   +15     
- Misses      34745    34750    +5     
  Partials     7141     7141           
Flag Coverage Δ
jsdom 50.82% <40.00%> (+<0.01%) ⬆️
node 15.56% <48.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ricbet Ricbet merged commit aeaa7be into main Jun 6, 2024
@Ricbet Ricbet deleted the feat/add-rpc-event-track branch June 6, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants