feat: optimize typescript interface navigation#3638
Merged
Conversation
|
This PR was not deployed automatically as @life2015 does not have access to the Railway project. In order to get automatic PR deploys, please add @life2015 to the project inside the project settings page. |
Ricbet
approved these changes
May 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3638 +/- ##
=======================================
Coverage 56.10% 56.10%
=======================================
Files 1513 1513
Lines 91785 91785
Branches 18818 18810 -8
=======================================
Hits 51498 51498
Misses 33410 33410
Partials 6877 6877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bytemain
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
优化 Typescript 场景下的 Interface 跳转功能，改成了只对 Interface 定义处增加快速跳转图标，取消了接口内部声明的跳转图标，避免编辑器左侧内容的混乱。
Background or solution
之前代码中对 Typescript 所有成员都有 Interface 快速跳转图标，但是在 Typescript 的场景中，接口成员很多并且相比 Java 而言空行和注释偏少，同时 Typescript 中对 Interface 用法也和 Java 有所不同，因此对 Typescript 做了逻辑精简。
Changelog