Skip to content

feat: optimize extension host restart logic#3635

Merged
bytemain merged 10 commits intomainfrom
fix/rpc-any-serializer
May 9, 2024
Merged

feat: optimize extension host restart logic#3635
bytemain merged 10 commits intomainfrom
fix/rpc-any-serializer

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented May 9, 2024

Types

  • 🎉 New Features

Background or solution

  1. 插件进程重启中的通知现在只会在真正重启的时候出现
  2. 移除后端通知进程不存在的逻辑,改为后端通知后前端直接重启
  3. 确保后端通知到前端重启

Changelog

optimize extension host restart logic

@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 9, 2024

🚅 Previously deployed to Railway in the main project. Environment has been deleted.

@opensumi opensumi Bot added the 🎨 feature feature required label May 9, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 53.37423% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 56.10%. Comparing base (9d25ea4) to head (01fce34).
Report is 8 commits behind head on main.

Files Patch % Lines
...ackages/extension/src/browser/extension.service.ts 4.34% 19 Missing and 3 partials ⚠️
...ges/extension/src/node/extension.service.client.ts 10.52% 14 Missing and 3 partials ⚠️
packages/utils/src/async.ts 6.25% 10 Missing and 5 partials ⚠️
packages/connection/src/common/fury-extends/any.ts 85.00% 9 Missing ⚠️
...ages/connection/src/common/rpc-service/registry.ts 50.00% 8 Missing and 1 partial ⚠️
...ckages/connection/src/common/rpc-service/center.ts 75.00% 2 Missing ⚠️
packages/connection/src/common/rpc/connection.ts 75.00% 1 Missing ⚠️
packages/utils/src/decorators.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3635      +/-   ##
==========================================
- Coverage   56.11%   56.10%   -0.01%     
==========================================
  Files        1513     1513              
  Lines       91744    91812      +68     
  Branches    18812    18817       +5     
==========================================
+ Hits        51480    51511      +31     
- Misses      33391    33423      +32     
- Partials     6873     6878       +5     
Flag Coverage Δ
jsdom 51.51% <46.01%> (-0.02%) ⬇️
node 15.68% <52.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytemain bytemain merged commit f2eae66 into main May 9, 2024
@bytemain bytemain deleted the fix/rpc-any-serializer branch May 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants