Skip to content

refactor: optimize SCM tree component initialization and remove warnings#3631

Merged
erha19 merged 1 commit intomainfrom
feat/improve-scm-perf-and-remove-warnings
May 9, 2024
Merged

refactor: optimize SCM tree component initialization and remove warnings#3631
erha19 merged 1 commit intomainfrom
feat/improve-scm-perf-and-remove-warnings

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented May 8, 2024

…for better resource management

Types

  • 🪚 Refactors
  • 🚀 Performance Improvements

Background or solution

移除了 SCMResourceTree 中对 mobx 的依赖逻辑

调整初始化时序移除警告

Changelog

optimize SCM tree component initialization and remove warnings

@erha19 erha19 requested review from Ricbet and bytemain May 8, 2024 08:39
@railway-app
Copy link
Copy Markdown

railway-app Bot commented May 8, 2024

This PR was not deployed automatically as @erha19 does not have access to the Railway project.

In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page.

@opensumi opensumi Bot added the ⚙️ refactor Refactor code label May 8, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 56.11%. Comparing base (9d25ea4) to head (56d4535).
Report is 2 commits behind head on main.

Files Patch % Lines
...onents/scm-resource-tree/scm-tree-model.service.ts 0.00% 5 Missing ⚠️
packages/scm/src/browser/scm-model.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3631      +/-   ##
==========================================
- Coverage   56.11%   56.11%   -0.01%     
==========================================
  Files        1513     1513              
  Lines       91744    91753       +9     
  Branches    18812    18812              
==========================================
+ Hits        51480    51484       +4     
- Misses      33391    33397       +6     
+ Partials     6873     6872       -1     
Flag Coverage Δ
jsdom 51.52% <11.11%> (-0.01%) ⬇️
node 15.66% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit b1c8234 into main May 9, 2024
@erha19 erha19 deleted the feat/improve-scm-perf-and-remove-warnings branch May 9, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants