Skip to content

fix: design module register menubar#3597

Merged
bytemain merged 11 commits intomainfrom
fix/register-menubar
Apr 30, 2024
Merged

fix: design module register menubar#3597
bytemain merged 11 commits intomainfrom
fix/register-menubar

Conversation

@bytemain
Copy link
Copy Markdown
Member

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Apr 29, 2024
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Apr 29, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714376841.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 56.01%. Comparing base (e2c3494) to head (85a0c6d).

Files Patch % Lines
packages/core-browser/src/layout/layout.ts 0.00% 12 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3597      +/-   ##
==========================================
- Coverage   56.01%   56.01%   -0.01%     
==========================================
  Files        1503     1502       -1     
  Lines       91459    91461       +2     
  Branches    18754    18750       -4     
==========================================
  Hits        51229    51229              
- Misses      33359    33360       +1     
- Partials     6871     6872       +1     
Flag Coverage Δ
jsdom 51.42% <0.00%> (-0.01%) ⬇️
node 15.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714385884.0

Comment thread packages/design/src/browser/menu-bar/menu-bar.view.tsx Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 29, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant

This comment was marked as resolved.

@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Apr 29, 2024

🎉 PR Next publish successful!

2.27.3-next-1714390086.0

@bytemain bytemain merged commit 6fe6636 into main Apr 30, 2024
@bytemain bytemain deleted the fix/register-menubar branch April 30, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants