Skip to content

feat: support set language id for output channel#3582

Merged
bytemain merged 1 commit intomainfrom
feat/support-set-lang-id-for-output
Apr 24, 2024
Merged

feat: support set language id for output channel#3582
bytemain merged 1 commit intomainfrom
feat/support-set-lang-id-for-output

Conversation

@bytemain
Copy link
Copy Markdown
Member

Types

  • 🎉 New Features

Background or solution

  1. we should bind LogOutputChannel's log methods.
  2. implements set language id

Changelog

@bytemain bytemain requested a review from Aaaaash April 23, 2024 12:52
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Apr 23, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi Bot added the 🎨 feature feature required label Apr 23, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 60.52632% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 56.02%. Comparing base (5d54570) to head (6b42cc1).

Files Patch % Lines
...extension/src/hosted/api/vscode/ext.host.output.ts 76.66% 7 Missing ⚠️
...nsion/src/browser/vscode/api/main.thread.output.ts 0.00% 3 Missing and 1 partial ⚠️
packages/output/src/browser/output.channel.ts 0.00% 3 Missing ⚠️
.../src/hosted/api/vscode/ext.host.window.api.impl.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3582      +/-   ##
==========================================
+ Coverage   56.01%   56.02%   +0.01%     
==========================================
  Files        1490     1490              
  Lines       91262    91292      +30     
  Branches    18716    18722       +6     
==========================================
+ Hits        51124    51150      +26     
- Misses      33279    33284       +5     
+ Partials     6859     6858       -1     
Flag Coverage Δ
jsdom 51.41% <60.52%> (+0.01%) ⬆️
node 15.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bytemain bytemain merged commit 8b30e78 into main Apr 24, 2024
@bytemain bytemain deleted the feat/support-set-lang-id-for-output branch April 24, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants