fix(diff-editor): optimize diff editor model caching and disposal handing#3572
Merged
fix(diff-editor): optimize diff editor model caching and disposal handing#3572
Conversation
|
This PR was not deployed automatically as @erha19 does not have access to the Railway project. In order to get automatic PR deploys, please add @erha19 to the project inside the project settings page. |
erha19
force-pushed
the
fix/editor-scroll-ux
branch
from
8200f1d to
2ad415a
Compare
Member
Author
|
/next |
Member
Author
|
/next |
Contributor
|
🎉 PR Next publish successful! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
=======================================
Coverage 56.03% 56.03%
=======================================
Files 1489 1489
Lines 91191 91193 +2
Branches 18697 18698 +1
=======================================
+ Hits 51098 51101 +3
+ Misses 33248 33246 -2
- Partials 6845 6846 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ricbet
approved these changes
Apr 23, 2024
bytemain
reviewed
Apr 30, 2024
| modified, | ||
| }); | ||
| const key = `${original.uri.toString()}-${modified.uri.toString()}`; | ||
| let model = this.diffEditorModelCache.get(key); |
Member
There was a problem hiding this comment.
还要再判断一下这个 model 是不是被 dispose 了，是的话要创建一个新的
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
close #3561.
Kapture.2024-04-22.at.16.52.14.mp4
Changelog
optimize diff editor model caching and disposal handing