Skip to content

fix: product icons contribution not initial#3469

Merged
erha19 merged 1 commit intomainfrom
fix/icons-contribution
Mar 28, 2024
Merged

fix: product icons contribution not initial#3469
erha19 merged 1 commit intomainfrom
fix/icons-contribution

Conversation

@AhkunTa
Copy link
Copy Markdown
Member

@AhkunTa AhkunTa commented Mar 28, 2024

Types

  • 🐛 Bug Fixes

Background or solution

  • fix product icons contribution not initial after icons contribution

Changelog

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Mar 28, 2024
@AhkunTa AhkunTa requested a review from erha19 March 28, 2024 09:03
Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 56.87%. Comparing base (0bb0671) to head (a2c594f).

Files Patch % Lines
packages/theme/src/browser/product-icon.service.ts 0.00% 2 Missing ⚠️
...s/extension/src/browser/vscode/contributes/icon.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3469      +/-   ##
==========================================
- Coverage   56.88%   56.87%   -0.01%     
==========================================
  Files        1461     1461              
  Lines       89430    89431       +1     
  Branches    18420    17399    -1021     
==========================================
- Hits        50869    50861       -8     
- Misses      35101    38547    +3446     
+ Partials     3460       23    -3437     
Flag Coverage Δ
jsdom 52.14% <40.00%> (-0.01%) ⬇️
node 15.87% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 481089a into main Mar 28, 2024
@erha19 erha19 deleted the fix/icons-contribution branch March 28, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants