Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3429 +/- ##
==========================================
- Coverage 57.14% 57.14% -0.01%
==========================================
Files 1441 1441
Lines 88874 88871 -3
Branches 18310 18309 -1
==========================================
- Hits 50784 50782 -2
+ Misses 34655 34654 -1
Partials 3435 3435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ricbet
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
close: #3089
这个原因是因为 monaco 查找 keybinding 的时候仅查找了它自己注册的那些快捷键,某些快捷键是 opensumi 绑定的,只是去调用了 monaco 相应的命令,所以比较简单的一个方案是重写一下 monaco lookup binding 的逻辑,先查内部的,再查外部的即可。
Changelog
Fix rename widget cannot show key code