Skip to content

fix(rpc): cancel cannot work#3382

Merged
Ricbet merged 1 commit intomainfrom
fix/rpc/cancel-requests
Mar 6, 2024
Merged

fix(rpc): cancel cannot work#3382
Ricbet merged 1 commit intomainfrom
fix/rpc/cancel-requests

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Mar 5, 2024

Types

  • 🐛 Bug Fixes

Background or solution

in #3362, we break the rpc cancel request logic, which is based on CancellationToken

here we add a test case to test cancel request.

Changelog

Fix rpc cancel request do not work

@bytemain bytemain requested review from Ricbet and erha19 March 5, 2024 13:33
@railway-app
Copy link
Copy Markdown

railway-app Bot commented Mar 5, 2024

This PR is being deployed to Railway 🚅

core: ◻️ REMOVED

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Mar 5, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.16%. Comparing base (1569088) to head (5384357).

Files Patch % Lines
packages/connection/src/common/fury-extends/any.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3382      +/-   ##
==========================================
- Coverage   58.16%   58.16%   -0.01%     
==========================================
  Files        1405     1403       -2     
  Lines       86676    86640      -36     
  Branches    17907    17903       -4     
==========================================
- Hits        50419    50391      -28     
+ Misses      32974    32966       -8     
  Partials     3283     3283              
Flag Coverage Δ
jsdom 53.01% <95.00%> (-0.02%) ⬇️
node 17.85% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ricbet Ricbet merged commit 146a76c into main Mar 6, 2024
@Ricbet Ricbet deleted the fix/rpc/cancel-requests branch March 6, 2024 02:26
@erha19 erha19 added the v3 OpenSumi 3.0 label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working v3 OpenSumi 3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants