fix: layout view state logic and improve panel style#3344
Merged
Conversation
|
This PR is being deployed to Railway 🚅 core: ◻️ REMOVED |
bytemain
reviewed
Feb 19, 2024
bytemain
requested changes
Feb 19, 2024
3f33532 to
8a0dc38
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3344 +/- ##
==========================================
+ Coverage 58.03% 58.07% +0.03%
==========================================
Files 1372 1372
Lines 85743 85754 +11
Branches 17734 17739 +5
==========================================
+ Hits 49762 49798 +36
+ Misses 32714 32694 -20
+ Partials 3267 3262 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
纯前端集成需要修改的内容:
- import { IRPCProtocol, RPCProtocol } from '@opensumi/ide-connection/lib/common/rpcProtocol';
+ import { IRPCProtocol, RPCProtocol } from '@opensumi/ide-connection/lib/common/ext-rpc-protocol';
需要保障 react 及 mobx 等依赖仅有一份
- externals: {
- react: 'React',
- 'react-dom': 'ReactDOM',
- },
|
Ricbet
reviewed
Feb 20, 2024
Ricbet
approved these changes
Feb 20, 2024
bytemain
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
Changelog