Skip to content

style: lint import statement#3308

Merged
bytemain merged 2 commits into
mainfrom
chore/add-lint
Jan 30, 2024
Merged

style: lint import statement#3308
bytemain merged 2 commits into
mainfrom
chore/add-lint

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Jan 26, 2024

Types

  • 🧹 Chores

Background or solution

使用这个包的时候,import 进来的命名千奇百怪的,加了个 lint 规则:import 进来的命名必须为 cls:

import cls from 'classnames';
image

Changelog

@bytemain bytemain force-pushed the chore/add-lint branch 2 times, most recently from 5ade9f3 to 2ed7721 Compare January 26, 2024 09:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (977e9d5) 57.76% compared to head (7a2fcd1) 57.75%.
Report is 1 commits behind head on main.

Files Patch % Lines
packages/editor/src/browser/decoration-applier.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3308      +/-   ##
==========================================
- Coverage   57.76%   57.75%   -0.02%     
==========================================
  Files        1357     1357              
  Lines       85004    85020      +16     
  Branches    17643    17646       +3     
==========================================
- Hits        49105    49103       -2     
- Misses      32629    32644      +15     
- Partials     3270     3273       +3     
Flag Coverage Δ
jsdom 52.63% <85.71%> (-0.02%) ⬇️
node 17.16% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19
Copy link
Copy Markdown
Member

erha19 commented Jan 29, 2024

clx 有啥讲究吗?平时 cls 用的多

@bytemain
Copy link
Copy Markdown
Member Author

clx 有啥讲究吗?平时 cls 用的多

ok 我看里面有用到 clx,我改一下

@bytemain
Copy link
Copy Markdown
Member Author

要不还是用 clx 吧,cls 的话需要人工介入一个个修改了

image

@erha19
Copy link
Copy Markdown
Member

erha19 commented Jan 29, 2024

@bytemain 这类写法应该不多,也不太规范,改了吧

@bytemain
Copy link
Copy Markdown
Member Author

@bytemain 这类写法应该不多,也不太规范,改了吧

ok

@bytemain bytemain changed the title chore: add classnames import lint style: lint import statement Jan 29, 2024
@bytemain bytemain merged commit ffba86a into main Jan 30, 2024
@bytemain bytemain deleted the chore/add-lint branch January 30, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants