Skip to content

feat: add sumi rpc#3284

Merged
erha19 merged 41 commits intomainfrom
feat/add-sumirpc
Feb 18, 2024
Merged

feat: add sumi rpc#3284
erha19 merged 41 commits intomainfrom
feat/add-sumirpc

Conversation

@bytemain
Copy link
Copy Markdown
Member

Types

  • 🎉 New Features

Background or solution

引入了 Sumi RPC,一个通用的 Node.js RPC 解决方案,使用 Fury 进行序列化。

Changelog

introduce a new rpc framework: sumi rpc, which is a general-purpose Node .js RPC solution, it use fury for serialization and deserialization

@opensumi opensumi Bot added the 🎨 feature feature required label Jan 18, 2024
@bytemain bytemain force-pushed the feat/add-sumirpc branch 2 times, most recently from 78749d8 to 685a963 Compare January 19, 2024 07:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2024

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (922ed90) 57.80% compared to head (86d524a) 57.97%.

Files Patch % Lines
packages/connection/src/common/rpc/connection.ts 79.06% 26 Missing and 1 partial ⚠️
packages/core-node/src/connection.ts 0.00% 18 Missing and 5 partials ⚠️
packages/connection/src/common/ws-channel.ts 70.73% 12 Missing ⚠️
...kages/connection/src/common/fury-extends/one-of.ts 74.28% 8 Missing and 1 partial ⚠️
...s/connection/src/common/rpc/protocol-repository.ts 83.33% 9 Missing ⚠️
packages/extension/src/common/vscode/connection.ts 55.00% 9 Missing ⚠️
...api/vscode/debug/abstract-debug-adapter-session.ts 47.05% 8 Missing and 1 partial ⚠️
packages/connection/src/common/proxy/sumi.ts 88.00% 6 Missing ⚠️
packages/connection/src/common/proxy/legacy.ts 91.07% 4 Missing and 1 partial ⚠️
...ckages/connection/src/common/rpc-service/center.ts 89.18% 4 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3284      +/-   ##
==========================================
+ Coverage   57.80%   57.97%   +0.17%     
==========================================
  Files        1357     1365       +8     
  Lines       85115    85486     +371     
  Branches    17642    17677      +35     
==========================================
+ Hits        49198    49559     +361     
- Misses      32646    32658      +12     
+ Partials     3271     3269       -2     
Flag Coverage Δ
jsdom 52.97% <67.83%> (+0.28%) ⬆️
node 17.50% <73.93%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jan 24, 2024

🎉 PR Next version 2.27.3-next-1706077936.0 publish successful! You can install this version via npm install package@2.27.3-next-1706077936.0

2.27.3-next-1706077936.0

@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jan 29, 2024

🎉 PR Next version 2.27.3-next-1706509546.0 publish successful! You can install this version via npm install package@2.27.3-next-1706509546.0

2.27.3-next-1706509546.0

Comment thread packages/connection/__test__/node/ws-channel.test.ts Outdated
Comment thread packages/connection/__test__/node/ws-channel.test.ts Outdated
Comment thread packages/utils/src/buffer.ts
Comment thread packages/utils/src/errors.ts
Comment thread packages/utils/src/errors.ts
@bytemain
Copy link
Copy Markdown
Member Author

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jan 31, 2024

🎉 PR Next version 2.27.3-next-1706686746.0 publish successful! You can install this version via npm install package@2.27.3-next-1706686746.0

2.27.3-next-1706686746.0

@bytemain bytemain mentioned this pull request Feb 4, 2024
1 task
@bytemain
Copy link
Copy Markdown
Member Author

bytemain commented Feb 5, 2024

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Feb 5, 2024

🎉 PR Next version 2.27.3-next-1707134083.0 publish successful! You can install this version via npm install package@2.27.3-next-1707134083.0

2.27.3-next-1707134083.0

@bytemain
Copy link
Copy Markdown
Member Author

bytemain commented Feb 6, 2024

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Feb 6, 2024

🎉 PR Next version 2.27.3-next-1707187308.0 publish successful! You can install this version via npm install package@2.27.3-next-1707187308.0

2.27.3-next-1707187308.0

@bytemain
Copy link
Copy Markdown
Member Author

bytemain commented Feb 6, 2024

我自己升级了一下,发现了以下的问题:

  • "typescript": "4.9.3",
  • ClientApp.start() 的第三个参数需要改成 Channel,或者不传
  • import { FileSystemWatcherServer } from '@opensumi/ide-file-service/lib/node/file-service-watcher';
    路径变了:'@opensumi/ide-file-service/lib/node/recursive/file-service-watcher'
  • 升级 mobx react

@bytemain
Copy link
Copy Markdown
Member Author

bytemain commented Feb 7, 2024

@erha19 可以试试这个版本,如果还有什么 breaking 的我再兼容掉

Copy link
Copy Markdown
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit d1aa884 into main Feb 18, 2024
@erha19 erha19 deleted the feat/add-sumirpc branch February 18, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants