Skip to content

feat: merged nsfw event#3251

Merged
erha19 merged 2 commits intomainfrom
fix/merge-events
Dec 21, 2023
Merged

feat: merged nsfw event#3251
erha19 merged 2 commits intomainfrom
fix/merge-events

Conversation

@pipiiiiii
Copy link
Copy Markdown
Contributor

Types

  • 🚀 Performance Improvements

Background or solution

copilot:walkthrough

fix: #3236

主要解决这个 issue 中的问题,尝试合并相同文件的事件,以为后续通过 onDidFilesChanged 也只会发出一次,所以没必要前置处理那么多次

Changelog

copilot:summary

@opensumi opensumi Bot added 🎨 feature feature required 🐞 bug Something isn't working labels Dec 21, 2023
@pipiiiiii
Copy link
Copy Markdown
Contributor Author

合并后

合并后事件显著减少,不会导致 cpu 占满

Comment thread packages/file-service/src/node/recursive/file-service-watcher.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d2efca5) 57.62% compared to head (415af0d) 57.63%.

Files Patch % Lines
...service/src/node/recursive/file-service-watcher.ts 94.11% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3251   +/-   ##
=======================================
  Coverage   57.62%   57.63%           
=======================================
  Files        1340     1340           
  Lines       84544    84557   +13     
  Branches    17587    17590    +3     
=======================================
+ Hits        48722    48737   +15     
  Misses      32553    32553           
+ Partials     3269     3267    -2     
Flag Coverage Δ
jsdom 52.55% <94.11%> (+<0.01%) ⬆️
node 16.87% <23.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 2650f80 into main Dec 21, 2023
@erha19 erha19 deleted the fix/merge-events branch December 21, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working 🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 进程长时间运行时,存在一段时间无响应情况

3 participants