Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
==========================================
+ Coverage 57.62% 57.70% +0.07%
==========================================
Files 1340 1357 +17
Lines 84557 84943 +386
Branches 17590 17639 +49
==========================================
+ Hits 48728 49018 +290
- Misses 32560 32654 +94
- Partials 3269 3271 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
requested changes
Dec 14, 2023
This reverts commit bb9dbf2.
Member
Author
|
我介绍一下这次的改动: 然后就是一些新增的代码,抽象出不同的通道(WS, net.Socket)的通信代码。 第二个就是优化了一下 RPCCenter 的架构,主要是代码重构,没有改太多逻辑,增加了一层 Proxy 抽象(方便加入 SumiRPC)。 第三个就是前后端通信都改成 WSChannel,无论 electron web,也优化了下 ws-channel 的通信消息 第四个就是 ext host 通信和 temrinal 通信改成 ws channel |
erha19
requested changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
针对 CommonHandler 的改造,能使其在后期兼容 Electron 端
介绍一下这次的改动:
第一个大改动就是统一所有的通信到 WSChannel,WSChannel 发送的数据包都是 fury 序列化后的,移除了目前所有的写死的依赖 jsonrpc 的 MessageConnection 的地方,都换成了 WSChannel
然后就是一些新增的代码,抽象出不同的通道(WS, net.Socket)的通信代码。
第二个就是优化了一下 RPCCenter 的架构,主要是代码重构,没有改太多逻辑,增加了一层 Proxy 抽象(方便加入 SumiRPC)。
第三个就是前后端通信都改成 WSChannel,无论 electron web,也优化了下 ws-channel 的通信消息
第四个就是 ext host 通信和 temrinal 通信改成 ws channel