Skip to content

fix: scm module support chinese title #2977#3219

Merged
erha19 merged 1 commit intoopensumi:mainfrom
zhuzeyu22:origin/merge2
Nov 30, 2023
Merged

fix: scm module support chinese title #2977#3219
erha19 merged 1 commit intoopensumi:mainfrom
zhuzeyu22:origin/merge2

Conversation

@zhuzeyu22
Copy link
Copy Markdown
Contributor

@zhuzeyu22 zhuzeyu22 commented Nov 28, 2023

Types

  • 🐛 Bug Fixes

Background or solution

🤖[deprecated] Generated by Copilot at f30e69d

  • Fix bug where SCM repository title shows full URI instead of basename (link)

Changelog

🤖[deprecated] Generated by Copilot at f30e69d

Fixed SCM repository title bug by using path instead of toString for rootUri. Changed getSCMRepositoryDesc function in packages/scm/src/browser/scm-util.ts.

@opensumi opensumi Bot added the 🐞 bug Something isn't working label Nov 28, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28aa219) 57.68% compared to head (f30e69d) 57.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3219      +/-   ##
==========================================
- Coverage   57.68%   57.67%   -0.01%     
==========================================
  Files        1340     1340              
  Lines       84535    84535              
  Branches    17583    17583              
==========================================
- Hits        48763    48759       -4     
- Misses      32512    32516       +4     
  Partials     3260     3260              
Flag Coverage Δ
jsdom 52.59% <100.00%> (-0.01%) ⬇️
node 16.87% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread packages/scm/src/browser/scm-util.ts
@erha19 erha19 linked an issue Nov 30, 2023 that may be closed by this pull request
@erha19 erha19 merged commit b42864c into opensumi:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] SCM 面板中文乱码及交互问题

2 participants