fix: scm module support chinese title #2977#3219
Merged
erha19 merged 1 commit intoopensumi:mainfrom Nov 30, 2023
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3219 +/- ##
==========================================
- Coverage 57.68% 57.67% -0.01%
==========================================
Files 1340 1340
Lines 84535 84535
Branches 17583 17583
==========================================
- Hits 48763 48759 -4
- Misses 32512 32516 +4
Partials 3260 3260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erha19
requested changes
Nov 30, 2023
Closed
erha19
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖[deprecated] Generated by Copilot at f30e69d
Changelog
🤖[deprecated] Generated by Copilot at f30e69d
Fixed SCM repository title bug by using
pathinstead oftoStringforrootUri. ChangedgetSCMRepositoryDescfunction inpackages/scm/src/browser/scm-util.ts.