fix: support DirectDebugAdapter debug type#3216
Merged
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
- Coverage 57.68% 57.67% -0.01%
==========================================
Files 1340 1340
Lines 84535 84543 +8
Branches 17583 17583
==========================================
- Hits 48763 48762 -1
- Misses 32512 32521 +9
Partials 3260 3260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
/next |
Contributor
|
🎉 PR Next version 2.27.2-next-1701084305.0 publish successful! You can install this version via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types
Background or solution
🤖[deprecated] Generated by Copilot at dca5a22
initializedrequest by setting theinitializedproperty totruein theDebugSessionclass (link)Emitterclass from the@opensumi/ide-core-commonpackage to create events for theDirectDebugAdapterclass (link)DebugStreamConnectioninterface in theDirectDebugAdapterclass, which requires theonClose,onMessageReceived,onError,start, andstopproperties and methods (link)startmethod of theDirectDebugAdapterclass, which arechannelandoutStream(link)close #3158.
Changelog
🤖[deprecated] Generated by Copilot at dca5a22
This pull request refactors the debug adapter communication and fixes a bug in the debug session initialization. It introduces the
DebugStreamConnectioninterface to standardize the communication between the debug adapter and the debug session, and removes unused parameters from theDirectDebugAdapterclass. It also adds a line of code and a comment to handle the case where the debug adapter does not send theinitializedrequest. The affected files areabstract-debug-adapter-session.ts,debug-session.ts, andextension-debug-adapter-starter.ts.