Skip to content

style: panel use default zIndex#3170

Merged
erha19 merged 30 commits intomainfrom
style/fix-panel-z-index
Nov 27, 2023
Merged

style: panel use default zIndex#3170
erha19 merged 30 commits intomainfrom
style/fix-panel-z-index

Conversation

@erha19
Copy link
Copy Markdown
Member

@erha19 erha19 commented Nov 15, 2023

Types

  • 💄 Style Changes

Background or solution

🤖 Generated by Copilot at 5bd8b6c

  • Removed zIndex property from tab panel styles to fix overlap bug (link)

移除无效的 zIndex 逻辑,这里会使得左右侧边栏的层级永远低于中间区域

修改后,所有视图布局均为同级,由内部组件自行控制层级

Changelog

🤖 Generated by Copilot at 5bd8b6c

Refactored the tab bar component to use React hooks and TypeScript and fixed a bug with tab panel styles. Removed the zIndex property from the panelVisible and panelInVisible styles in panel.view.tsx to prevent overlapping with other UI elements.

@opensumi opensumi Bot added 💄 style change 🐞 bug Something isn't working labels Nov 15, 2023
@erha19 erha19 force-pushed the style/fix-panel-z-index branch from 98e1751 to 0832ada Compare November 23, 2023 15:13
Comment thread .github/workflows/check.yml Outdated
Comment thread .github/workflows/deploy.yml Outdated
Comment thread .github/workflows/release-rc.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ee98e5) 57.69% compared to head (51d6a6a) 57.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3170      +/-   ##
==========================================
- Coverage   57.69%   57.67%   -0.02%     
==========================================
  Files        1340     1340              
  Lines       84533    84535       +2     
  Branches    17583    17583              
==========================================
- Hits        48770    48759      -11     
- Misses      32502    32516      +14     
+ Partials     3261     3260       -1     
Flag Coverage Δ
jsdom 52.59% <ø> (-0.02%) ⬇️
node 16.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erha19 erha19 merged commit 28aa219 into main Nov 27, 2023
@erha19 erha19 deleted the style/fix-panel-z-index branch November 27, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working 💄 style change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants