Skip to content

fix: terminal shortcut kill process in windows#3100

Merged
erha19 merged 2 commits intomainfrom
fix/terminal-shortcut-kill-process
Oct 10, 2023
Merged

fix: terminal shortcut kill process in windows#3100
erha19 merged 2 commits intomainfrom
fix/terminal-shortcut-kill-process

Conversation

@shilin8805
Copy link
Copy Markdown
Contributor

@shilin8805 shilin8805 commented Oct 7, 2023

Types

  • 🐛 Bug Fixes

Background or solution

解决window操作系统终端中使用ctrl+c无法结束进程的问题

🤖 Generated by Copilot at 632596e

  • Add a new command KILL_PROCESS to kill the current process or copy the selection in the terminal widget (link)
  • Implement the logic for executing the KILL_PROCESS command in terminal.command.ts (link)
  • Add a keybinding for the KILL_PROCESS command in terminal.keybinding.ts (link)
  • Add localization labels for the KILL_PROCESS command in en-US.lang.ts and zh-CN.lang.ts (link, link)

Changelog

🤖 Generated by Copilot at 632596e

This pull request adds a new KILL_PROCESS command to the terminal widget that can either kill the current process or copy the selected text to the clipboard. It also adds the corresponding localization and keybinding for the command.

@erha19
Copy link
Copy Markdown
Member

erha19 commented Oct 7, 2023

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Oct 7, 2023

🎉 PR Next version 2.26.9-next-1696669963.0 publish successful! You can install this version via npm install [email protected]

2.26.9-next-1696669963.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/core-browser/src/common/common.command.ts 100.00% <100.00%> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)
...xt/src/browser/contribution/terminal.keybinding.ts 0.00% <0.00%> (ø)
...-next/src/browser/contribution/terminal.command.ts 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

erha19
erha19 previously approved these changes Oct 10, 2023
@erha19
Copy link
Copy Markdown
Member

erha19 commented Oct 10, 2023

@shilin8805 合并到 main 跟随主版本发布了

@erha19 erha19 changed the base branch from v2.26 to main October 10, 2023 09:44
@erha19 erha19 dismissed their stale review October 10, 2023 09:44

The base branch was changed.

@erha19 erha19 merged commit e5f1ac5 into main Oct 10, 2023
@erha19 erha19 deleted the fix/terminal-shortcut-kill-process branch October 10, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants