Skip to content

feat: notification support button#3073

Merged
pipiiiiii merged 1 commit intomainfrom
feat/notification-support-button
Sep 20, 2023
Merged

feat: notification support button#3073
pipiiiiii merged 1 commit intomainfrom
feat/notification-support-button

Conversation

@pipiiiiii
Copy link
Copy Markdown
Contributor

@pipiiiiii pipiiiiii commented Sep 19, 2023

Types

  • 🎉 New Features

Background or solution

🤖 Generated by Copilot at 4420f09

  • Imported the IAction interface from @opensumi/ide-core-common in notification component and progress service (link, link)
  • Changed the buttons parameter of the open function in notification component and the buttons option of the IProgressOptions interface in progress service and utility to accept an array of strings or IAction objects (link, link, link)
  • Modified the logic for rendering the notification buttons in the open function to handle both string and IAction types and to apply the corresponding props and actions for each button (link)
  • Passed the buttons option from the progress service to the notification component in the createNotification method (link)
  • Updated the IAction interface in the progress utility to make some properties optional and to add a primary property (link)
  • notification 支持按钮
    • 新效果
      刷新
    • 兼容原有取消按钮
      刷新+cancle

Changelog

🤖 Generated by Copilot at 4420f09

Enhanced the notification component and related services and utilities to allow custom actions and props for the notification buttons. This enables more flexibility and interactivity for displaying progress and feedback to the user. Used the IAction interface from @opensumi/ide-core-common to define the button options.

@opensumi opensumi Bot added the 🎨 feature feature required label Sep 19, 2023
@pipiiiiii pipiiiiii merged commit 140f232 into main Sep 20, 2023
@pipiiiiii pipiiiiii deleted the feat/notification-support-button branch September 20, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants